Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296496: Overzealous check in sizecalc.h prevents large memory allocation #194

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Nov 24, 2022

Hi all,
This pull request contains a backport of commit 84e12244 from the openjdk/jdk repository.
The commit being backported was authored by Alexander Zuev on 10 Nov 2022 and was reviewed by Alexey Ivanov and Alexander Zvegintsev.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296496: Overzealous check in sizecalc.h prevents large memory allocation

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/194/head:pull/194
$ git checkout pull/194

Update a local copy of the PR:
$ git checkout pull/194
$ git pull https://git.openjdk.org/jdk8u-dev pull/194/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 194

View PR using the GUI difftool:
$ git pr show -t 194

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/194.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 24, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 84e12244a4ff82b3307a5ffe6fbe9dded7b08d86 8296496: Overzealous check in sizecalc.h prevents large memory allocation Nov 24, 2022
@openjdk
Copy link

openjdk bot commented Nov 24, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Nov 24, 2022
@mrserb mrserb marked this pull request as ready for review November 25, 2022 09:20
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 25, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 25, 2022

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Dec 1, 2022

/clean The change is identical to the upstream

@openjdk openjdk bot added the clean label Dec 1, 2022
@openjdk
Copy link

openjdk bot commented Dec 1, 2022

@mrserb This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Dec 1, 2022

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8296496: Overzealous check in sizecalc.h prevents large memory allocation

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 8356d04: 8295982: Failure in sun/security/tools/keytool/WeakAlg.java - ks: The process cannot access the file because it is being used by another process
  • fcd3c9c: 8247676: vcruntime140_1.dll is not needed on 32-bit Windows
  • 1ec7984: 8242468: VS2019 build missing vcruntime140_1.dll
  • 918a2ab: 8241087: Build failure with VS 2019 (16.5.0) due to C2039 and C2873
  • 7b54850: 8297329: [8u] hotspot needs to recognise VS2019
  • e9acfce: 8295322: Tests for JDK-8271459 were not backported to 11u
  • 7eb2803: 8230305: Cgroups v2: Container awareness
  • 3b1bbef: 8297739: Bump update version of OpenJDK: 8u372
  • 41159a5: 8255559: Leak File Descriptors Because of ResolverLocalFilesystem#engineResolveURI()
  • df44cbf: 8073464: GC workers do not have thread names
  • ... and 1 more: https://git.openjdk.org/jdk8u-dev/compare/c501bfaa5fc2502942b228c907372dccd58c4a20...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 1, 2022
@mrserb
Copy link
Member Author

mrserb commented Dec 6, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 6, 2022

Going to push as commit da681cf.
Since your change was applied there have been 20 commits pushed to the master branch:

  • d13b813: 8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox
  • 2abc206: 8257620: Do not use objc_msgSend_stret to get macOS version
  • 72269ee: 8296632: Write a test to verify the content change of TextArea sends TextEvent
  • a983a00: 6829250: Reg test: java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java fails in Windows
  • 4388fa8: 8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException
  • 21a1236: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing
  • c9007cd: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
  • 5510145: 8226236: win32: gc/metaspace/TestCapacityUntilGCWrapAround.java fails
  • 77403ed: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3
  • 8356d04: 8295982: Failure in sun/security/tools/keytool/WeakAlg.java - ks: The process cannot access the file because it is being used by another process
  • ... and 10 more: https://git.openjdk.org/jdk8u-dev/compare/c501bfaa5fc2502942b228c907372dccd58c4a20...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 6, 2022
@openjdk openjdk bot closed this Dec 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 6, 2022
@openjdk
Copy link

openjdk bot commented Dec 6, 2022

@mrserb Pushed as commit da681cf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant