Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3 #199

Closed
wants to merge 1 commit into from

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Nov 29, 2022

Backport for JDK-8286624 Regression Test CoordinateTruncationBug.java fails on OL8.3

Clean Backport, but the test needs to be moved due to 8 directory structure
New test, low risk.
Test passes during manual run on linux and mac.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/199/head:pull/199
$ git checkout pull/199

Update a local copy of the PR:
$ git checkout pull/199
$ git pull https://git.openjdk.org/jdk8u-dev pull/199/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 199

View PR using the GUI difftool:
$ git pr show -t 199

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/199.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 29, 2022

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7964440dd3274b84713c0debe1846092bb6d6d68 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3 Nov 29, 2022
@openjdk
Copy link

openjdk bot commented Nov 29, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 29, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 29, 2022

Webrevs

@phohensee
Copy link
Member

/clean

@openjdk openjdk bot added the clean label Nov 29, 2022
@openjdk
Copy link

openjdk bot commented Nov 29, 2022

@phohensee This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Nov 29, 2022

@Rudometov This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 8356d04: 8295982: Failure in sun/security/tools/keytool/WeakAlg.java - ks: The process cannot access the file because it is being used by another process
  • fcd3c9c: 8247676: vcruntime140_1.dll is not needed on 32-bit Windows
  • 1ec7984: 8242468: VS2019 build missing vcruntime140_1.dll
  • 918a2ab: 8241087: Build failure with VS 2019 (16.5.0) due to C2039 and C2873
  • 7b54850: 8297329: [8u] hotspot needs to recognise VS2019
  • e9acfce: 8295322: Tests for JDK-8271459 were not backported to 11u
  • 7eb2803: 8230305: Cgroups v2: Container awareness
  • 3b1bbef: 8297739: Bump update version of OpenJDK: 8u372

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 29, 2022
@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 1, 2022
@openjdk
Copy link

openjdk bot commented Dec 1, 2022

@Rudometov
Your change (at version 505a070) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 1, 2022

Going to push as commit 77403ed.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 8356d04: 8295982: Failure in sun/security/tools/keytool/WeakAlg.java - ks: The process cannot access the file because it is being used by another process
  • fcd3c9c: 8247676: vcruntime140_1.dll is not needed on 32-bit Windows
  • 1ec7984: 8242468: VS2019 build missing vcruntime140_1.dll
  • 918a2ab: 8241087: Build failure with VS 2019 (16.5.0) due to C2039 and C2873
  • 7b54850: 8297329: [8u] hotspot needs to recognise VS2019
  • e9acfce: 8295322: Tests for JDK-8271459 were not backported to 11u
  • 7eb2803: 8230305: Cgroups v2: Container awareness
  • 3b1bbef: 8297739: Bump update version of OpenJDK: 8u372

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 1, 2022
@openjdk openjdk bot closed this Dec 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 1, 2022
@openjdk
Copy link

openjdk bot commented Dec 1, 2022

@phohensee @Rudometov Pushed as commit 77403ed.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Dec 4, 2022

Mailing list message from Bernd on jdk8u-dev:

An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20221204/5dc36c21/attachment.htm>

@Rudometov Rudometov deleted the 8286624 branch April 13, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants