Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298307: Enable hotspot/tier1 for 32-bit builds in GHA for 8u #204

Closed
wants to merge 1 commit into from

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Dec 7, 2022

All issues in hotspot/tier1 affecting 32-bit builds are now resolved so these configurations can now be enabled in GHA. This is the last piece to have full tier1 testing on all platforms we have in GHA.

Notes:

  • hotspot/tier1 on linux requires working C/C++ compiler for some tests (gcc multilib packages are required for linux-x86)
  • hotspot/tier1 contains some container tests, but ubuntu:latest does not include 32-bit libs by default. Multilib image needs to be created.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298307: Enable hotspot/tier1 for 32-bit builds in GHA for 8u

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/204/head:pull/204
$ git checkout pull/204

Update a local copy of the PR:
$ git checkout pull/204
$ git pull https://git.openjdk.org/jdk8u-dev pull/204/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 204

View PR using the GUI difftool:
$ git pr show -t 204

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/204.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 7, 2022

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 7, 2022
@zzambers zzambers changed the title 8298307: Enable hotspot/tier1 testing on x86 8298307: Enable hotspot/tier1 for 32-bit builds in GHA for 8u Dec 7, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 7, 2022

Webrevs

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@openjdk
Copy link

openjdk bot commented Dec 9, 2022

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8298307: Enable hotspot/tier1 for 32-bit builds in GHA for 8u

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 362cf76: 8237479: 8230305 causes slowdebug build failure

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 9, 2022
@zzambers
Copy link
Contributor Author

@jerboaa Thank you for review

@zzambers
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 12, 2022
@openjdk
Copy link

openjdk bot commented Dec 12, 2022

@zzambers
Your change (at version 2162067) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Dec 12, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 12, 2022

Going to push as commit c84a5b2.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 362cf76: 8237479: 8230305 causes slowdebug build failure

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 12, 2022
@openjdk openjdk bot closed this Dec 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 12, 2022
@openjdk
Copy link

openjdk bot commented Dec 12, 2022

@jerboaa @zzambers Pushed as commit c84a5b2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants