8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec

[phohensee]

Backport for Oracle parity from 11u is almost clean.

1. PKCS11Test.java is unchanged because 8u does not throw a RuntimeException for an unknown command.
2. In TestP11KeyFactoryGetRSAKeySpec.java, /test/lib is unneeded in the @library comment, and the @module comment was deleted.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/214/head:pull/214
$ git checkout pull/214

Update a local copy of the PR:
$ git checkout pull/214
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/214/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 214

View PR using the GUI difftool:
$ git pr show -t 214

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/214.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back phh! A progress list of the required criteria for merging this PR into pr/211 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (c5b08d4f)
• 00: Full (c5b08d4f)

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout backport-a5d7de23
git fetch https://git.openjdk.org/jdk8u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[gnu-andrew]

Changes mostly look ok, but will need a rebase before push.

Is there a reason the *_SHA3_* definitions have been removed from p11-nss-sensitive.txt? Those should be defined, having been added by JDK-8244154

[bridgekeeper]

@phohensee This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@phohensee This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[mrserb]

@gnu-andrew @phohensee this fix should be merged into the upcoming openjdk8u382

[phohensee]

/open

[openjdk]

@phohensee This pull request is now open

[mrserb]

this PR is for /8u-dev, we probably need to recreate it for /8u

[phohensee]

This PR was incorrectly based on the original JDK 17 commit rather than the 11u backport. Closing.