Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284977: MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't exist #215

Closed

Conversation

kurashige23
Copy link
Contributor

@kurashige23 kurashige23 commented Dec 20, 2022

Hi all,

I'd like to backport this to jdk8u-dev.
It fixes a test failure caused by cgroups virtual files (nr_periods etc) not existing in some circumstances.

Thanks.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284977: MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't exist

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/215/head:pull/215
$ git checkout pull/215

Update a local copy of the PR:
$ git checkout pull/215
$ git pull https://git.openjdk.org/jdk8u-dev pull/215/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 215

View PR using the GUI difftool:
$ git pr show -t 215

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/215.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2022

👋 Welcome back kurashige23! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 20, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 20, 2022

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented Dec 20, 2022

@kurashige23 Please change the PR title to Backport 444a0d98ac06ab043e3b11281234fd515abff302 as that would make the bots recognize this properly as a backport. Thanks! Please also enable GHA testing on your fork. Instructions should be provided as to how to do that.

@kurashige23 kurashige23 changed the title 8284977: MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't exist Backport 444a0d98ac06ab043e3b11281234fd515abff302 Dec 21, 2022
@openjdk openjdk bot changed the title Backport 444a0d98ac06ab043e3b11281234fd515abff302 8284977: MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't exist Dec 21, 2022
@openjdk
Copy link

openjdk bot commented Dec 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Dec 21, 2022
@kurashige23
Copy link
Contributor Author

@jerboaa I'm sorry for some mistakes. I fixed PR title and enabled GHA testing. Is that all right?

@jerboaa
Copy link
Contributor

jerboaa commented Dec 21, 2022

Clean backport (only path changes). Marking as such.

/clean

@openjdk openjdk bot added the clean label Dec 21, 2022
@openjdk
Copy link

openjdk bot commented Dec 21, 2022

@jerboaa This backport pull request is now marked as clean

@jerboaa
Copy link
Contributor

jerboaa commented Dec 21, 2022

@kurashige23 Please proceed with applying for JDK 8u backports approval as described in Contributing section here:
https://wiki.openjdk.org/display/jdk8u

@openjdk
Copy link

openjdk bot commented Dec 21, 2022

⚠️ @kurashige23 the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout kurashige23-backport-444a0d98
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Dec 21, 2022

@kurashige23 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8284977: MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't exist

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 21, 2022
@kurashige23
Copy link
Contributor Author

@jerboaa Thank you for giving the link.
Should I add the 'jdk8u-fix-request' label? But I don't have access to the OpenJDK bug system. If possible, Could you please add a label for me?

@jerboaa
Copy link
Contributor

jerboaa commented Dec 22, 2022

Should I add the 'jdk8u-fix-request' label? But I don't have access to the OpenJDK bug system. If possible, Could you please add a label for me?

Yes. I've added them for you and approved as it's a test-only bug. Feel free to integrate.

@kurashige23
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 23, 2022
@openjdk
Copy link

openjdk bot commented Dec 23, 2022

@kurashige23
Your change (at version 4bbc576) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Dec 23, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 23, 2022

Going to push as commit b4a745d.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 23, 2022
@openjdk openjdk bot closed this Dec 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 23, 2022
@openjdk
Copy link

openjdk bot commented Dec 23, 2022

@jerboaa @kurashige23 Pushed as commit b4a745d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants