-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge jdk8u:master #230
Merge jdk8u:master #230
Conversation
Reviewed-by: andrew Backport-of: 9d3b4ef2ad658afb5379796b7224458c12c81f5d
… if keysize is weak/disabled Reviewed-by: phh, andrew Backport-of: 03f8c0fb9363dc1bb07bed1ae0359c029caa0130
Reviewed-by: dcherepanov, sgehwolf Backport-of: da9de488990ff47fe06343439f2180ec1b2a3061
Reviewed-by: dcherepanov, sgehwolf Backport-of: ce896731d38866c2bf99cd49525062e150d94160
… signed JAR Reviewed-by: andrew Backport-of: a0f6f2409ea61ff9ed9dc2e2b46e309c751d456d
Co-authored-by: Joshua Cao <joshcao@amazon.com> Reviewed-by: mbalao, bae, andrew
Reviewed-by: andrew Backport-of: e733e55de88e63e129f15edefc602c050339b38a
Reviewed-by: mbalao, andrew Backport-of: 4c7b057380d7656c8c275b526d1918de6a625cc4
Reviewed-by: mbalao, andrew Backport-of: 8278c12ceff28681a8e8cde8dd49ee9a79eaf25e
Reviewed-by: andrew Backport-of: ca126c9025ad975d9086d5f967d35a76425c13ca
Reviewed-by: mbalao, andrew Backport-of: a2668f58ccc3b7c7d74e2903128b08d97aac5798
Reviewed-by: mbalao, andrew Backport-of: fb692840530fa07174f9ad5c9f77d593e503a155
Reviewed-by: mbalao, andrew Backport-of: 40959ac32b81c333f04628be227107762b78a7da
Reviewed-by: mbalao, andrew Backport-of: f1de79f38fcff10ccaf232f79df0a94e84751ff7
Reviewed-by: mbalao, andrew Backport-of: 4df2fd2d1ca8ed73de6ac8b2f6a51ff93e3dac6d
…rtion Error Reviewed-by: andrew Backport-of: e94ca7d3fc9b5946d5b808f98e334529054c4f39
Reviewed-by: phh, andrew Backport-of: c4dc58e12e197562dce90c0027aa74c29047cea6
Reviewed-by: dcherepanov Backport-of: 03a5c254d36a51d478b3c1042f0fb6f2c7453dc6
Reviewed-by: dcherepanov Backport-of: e3eccbcbc2e27921c058d43b81fb113d10be2dab
Reviewed-by: dcherepanov Backport-of: ff60b348813fd7e32bdda322f345f90311a60207
…hr_HR 8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java Reviewed-by: dcherepanov, sgehwolf Backport-of: 80eecc50e663155f04dcec1797efb4be4b8ee7b2
Added tag jdk8u362-b08 for changeset 056d5a7
👋 Welcome back andrew! A progress list of the required criteria for merging this PR into |
@gnu-andrew This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Merge of Anyway, 32 bit Windows GHA failure seems legit. @stooke Could you please take a look when you get a chance? |
@stooke tells me that we need this one to fix it: @gnu-andrew Any thoughts why that isn't part of the merge? |
https://github.com/openjdk/jdk8u/compare/jdk8u362-b08...jdk8u362-b09?expand=1 suggests it's part of the |
Yeah, failure was expected. I wanted to see if GHA would have caught it if it had been public, so only merged b08. |
/integrate |
Going to push as commit ddb9a5c. |
@gnu-andrew Pushed as commit ddb9a5c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Merge
8u362-b08
to 8u-devProgress
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/230/head:pull/230
$ git checkout pull/230
Update a local copy of the PR:
$ git checkout pull/230
$ git pull https://git.openjdk.org/jdk8u-dev pull/230/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 230
View PR using the GUI difftool:
$ git pr show -t 230
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/230.diff