Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge jdk8u:master #230

Closed
wants to merge 22 commits into from
Closed

Merge jdk8u:master #230

wants to merge 22 commits into from

Conversation

gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Jan 18, 2023

Merge 8u362-b08 to 8u-dev


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/230/head:pull/230
$ git checkout pull/230

Update a local copy of the PR:
$ git checkout pull/230
$ git pull https://git.openjdk.org/jdk8u-dev pull/230/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 230

View PR using the GUI difftool:
$ git pr show -t 230

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/230.diff

Sorry, something went wrong.

Dmitry Cherepanov and others added 22 commits November 30, 2022 16:25
Reviewed-by: andrew
Backport-of: 9d3b4ef2ad658afb5379796b7224458c12c81f5d
… if keysize is weak/disabled

Reviewed-by: phh, andrew
Backport-of: 03f8c0fb9363dc1bb07bed1ae0359c029caa0130
Reviewed-by: dcherepanov, sgehwolf
Backport-of: da9de488990ff47fe06343439f2180ec1b2a3061
Reviewed-by: dcherepanov, sgehwolf
Backport-of: ce896731d38866c2bf99cd49525062e150d94160
… signed JAR

Reviewed-by: andrew
Backport-of: a0f6f2409ea61ff9ed9dc2e2b46e309c751d456d
Co-authored-by: Joshua Cao <joshcao@amazon.com>
Reviewed-by: mbalao, bae, andrew
Reviewed-by: andrew
Backport-of: e733e55de88e63e129f15edefc602c050339b38a
Reviewed-by: mbalao, andrew
Backport-of: 4c7b057380d7656c8c275b526d1918de6a625cc4
Reviewed-by: mbalao, andrew
Backport-of: 8278c12ceff28681a8e8cde8dd49ee9a79eaf25e
Reviewed-by: andrew
Backport-of: ca126c9025ad975d9086d5f967d35a76425c13ca
Reviewed-by: mbalao, andrew
Backport-of: a2668f58ccc3b7c7d74e2903128b08d97aac5798
Reviewed-by: mbalao, andrew
Backport-of: fb692840530fa07174f9ad5c9f77d593e503a155
Reviewed-by: mbalao, andrew
Backport-of: 40959ac32b81c333f04628be227107762b78a7da
Reviewed-by: mbalao, andrew
Backport-of: f1de79f38fcff10ccaf232f79df0a94e84751ff7
Reviewed-by: mbalao, andrew
Backport-of: 4df2fd2d1ca8ed73de6ac8b2f6a51ff93e3dac6d
…rtion Error

Reviewed-by: andrew
Backport-of: e94ca7d3fc9b5946d5b808f98e334529054c4f39
Reviewed-by: phh, andrew
Backport-of: c4dc58e12e197562dce90c0027aa74c29047cea6
Reviewed-by: dcherepanov
Backport-of: 03a5c254d36a51d478b3c1042f0fb6f2c7453dc6
Reviewed-by: dcherepanov
Backport-of: e3eccbcbc2e27921c058d43b81fb113d10be2dab
Reviewed-by: dcherepanov
Backport-of: ff60b348813fd7e32bdda322f345f90311a60207
…hr_HR

8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java

Reviewed-by: dcherepanov, sgehwolf
Backport-of: 80eecc50e663155f04dcec1797efb4be4b8ee7b2
Added tag jdk8u362-b08 for changeset 056d5a7
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 18, 2023

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 18, 2023

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

Merge

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 18, 2023
@jerboaa
Copy link
Contributor

jerboaa commented Jan 18, 2023

Merge of jdk8u362-b09 over jdk8u362-b08?

Anyway, 32 bit Windows GHA failure seems legit. @stooke Could you please take a look when you get a chance?

@jerboaa
Copy link
Contributor

jerboaa commented Jan 18, 2023

Anyway, 32 bit Windows GHA failure seems legit. @stooke Could you please take a look when you get a chance?

@stooke tells me that we need this one to fix it:
openjdk/jdk8u@36321be

@gnu-andrew Any thoughts why that isn't part of the merge?

@jerboaa
Copy link
Contributor

jerboaa commented Jan 18, 2023

https://github.com/openjdk/jdk8u/compare/jdk8u362-b08...jdk8u362-b09?expand=1 suggests it's part of the jdk8u362-b09 merge :)

@gnu-andrew
Copy link
Member Author

Merge of jdk8u362-b09 over jdk8u362-b08?

Anyway, 32 bit Windows GHA failure seems legit. @stooke Could you please take a look when you get a chance?

Yeah, failure was expected. I wanted to see if GHA would have caught it if it had been public, so only merged b08.
Also, I noticed I used the wrong ID on the commit in jdk8u so will fix that in the jdk8u-dev version, so there is a least one version with the right ID.

@gnu-andrew
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 18, 2023

Going to push as commit ddb9a5c.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 18, 2023
@openjdk openjdk bot closed this Jan 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 18, 2023
@openjdk
Copy link

openjdk bot commented Jan 18, 2023

@gnu-andrew Pushed as commit ddb9a5c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

3 participants