Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7001973: java/awt/Graphics2D/CopyAreaOOB.java fails #241

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jan 25, 2023

I backport this for parity with 8u361.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-7001973: java/awt/Graphics2D/CopyAreaOOB.java fails

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/241/head:pull/241
$ git checkout pull/241

Update a local copy of the PR:
$ git checkout pull/241
$ git pull https://git.openjdk.org/jdk8u-dev pull/241/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 241

View PR using the GUI difftool:
$ git pr show -t 241

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/241.diff

Backport-of: 22b7295e75d3bc7ba2c2cd7b871bb2bb5bf290eb
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 25, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 22b7295e75d3bc7ba2c2cd7b871bb2bb5bf290eb 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails Jan 25, 2023
@openjdk
Copy link

openjdk bot commented Jan 25, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jan 25, 2023
@mrserb
Copy link
Member Author

mrserb commented Jan 25, 2023

/clean The change itself is the same, but the update of the problem list is skipped.

@mrserb mrserb marked this pull request as ready for review January 25, 2023 23:06
@openjdk openjdk bot added rfr Pull request is ready for review clean labels Jan 25, 2023
@openjdk
Copy link

openjdk bot commented Jan 25, 2023

@mrserb This backport pull request is now marked as clean

@mrserb
Copy link
Member Author

mrserb commented Jan 25, 2023

Windows build issue is unrelated:

curl: (28) Failed to connect to web.archive.org port 443 after 21072 ms: Timed out
Get-FileHash: D:\a_temp\44775925-3601-4297-8f6a-a5989242e6cb.ps1:4
Line |
4 | $FileHash = Get-FileHash -Algorithm SHA256 "$HOME/$env:VS2010_FILENAM …
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| Cannot find path 'C:\Users\runneradmin\VS2010Express1.iso' because it does not exist.

@openjdk
Copy link

openjdk bot commented Jan 25, 2023

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7001973: java/awt/Graphics2D/CopyAreaOOB.java fails

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 25, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 25, 2023

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Jan 27, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 27, 2023

Going to push as commit 85050ef.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 92c9aed: 8039888: [TEST_BUG] keyboard garbage after javax/swing/plaf/windows/WindowsRootPaneUI/WrongAltProcessing/WrongAltProcessing.java
  • 5274069: 8196467: javax/swing/JInternalFrame/Test6325652.java fails
  • c3c871e: 8159135: [PIT] javax/swing/JMenuItem/8152981/MenuItemIconTest.java always fail
  • 8192d03: 8293767: AWT test TestSinhalaChar.java has old SCCS markings
  • d0cbcc5: 8301122: [8u] Fix unreliable vs2010 download link

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 27, 2023
@openjdk openjdk bot closed this Jan 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 27, 2023
@openjdk
Copy link

openjdk bot commented Jan 27, 2023

@mrserb Pushed as commit 85050ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the 7001973 branch January 27, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants