New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8298027: Remove SCCS id's from awt jtreg tests #264
Conversation
👋 Welcome back serb! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
Something strange here in that this appears to be a clean backport but was not recognized as such by the bot.
@mrserb This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/clean The change is identical to the jdk/jdk |
@mrserb This backport pull request is now marked as clean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed clean and approved.
I don't think the bot marks 8u backports as clean, due to the path shuffling. At least, I've not seen it happen so far. |
/integrate |
Going to push as commit b71f59b.
Your commit was automatically rebased without conflicts. |
Hi all,
This pull request contains a backport of commit ba2d28e9 from the openjdk/jdk repository.
The commit being backported was authored by Jayathirth D V on 6 Dec 2022 and was reviewed by Alexey Ivanov.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/264/head:pull/264
$ git checkout pull/264
Update a local copy of the PR:
$ git checkout pull/264
$ git pull https://git.openjdk.org/jdk8u-dev pull/264/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 264
View PR using the GUI difftool:
$ git pr show -t 264
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/264.diff