Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298027: Remove SCCS id's from awt jtreg tests #264

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Feb 6, 2023

Hi all,
This pull request contains a backport of commit ba2d28e9 from the openjdk/jdk repository.
The commit being backported was authored by Jayathirth D V on 6 Dec 2022 and was reviewed by Alexey Ivanov.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/264/head:pull/264
$ git checkout pull/264

Update a local copy of the PR:
$ git checkout pull/264
$ git pull https://git.openjdk.org/jdk8u-dev pull/264/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 264

View PR using the GUI difftool:
$ git pr show -t 264

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/264.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 6, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ba2d28e911f4f523334f98fd0186680acafb6f0a 8298027: Remove SCCS id's from awt jtreg tests Feb 6, 2023
@openjdk
Copy link

openjdk bot commented Feb 6, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Feb 6, 2023
@mrserb mrserb marked this pull request as ready for review February 6, 2023 07:13
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 6, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 6, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

Something strange here in that this appears to be a clean backport but was not recognized as such by the bot.

@openjdk
Copy link

openjdk bot commented Feb 6, 2023

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8298027: Remove SCCS id's from awt jtreg tests

Reviewed-by: phh, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • fbaabf3: 8301620: [8u] some shell tests are passed but have unexpected operator errors
  • 8c42e20: 8287109: Distrust.java failed with CertificateExpiredException

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 6, 2023
@mrserb
Copy link
Member Author

mrserb commented Feb 6, 2023

/clean The change is identical to the jdk/jdk

@openjdk openjdk bot added the clean label Feb 6, 2023
@openjdk
Copy link

openjdk bot commented Feb 6, 2023

@mrserb This backport pull request is now marked as clean

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed clean and approved.

@gnu-andrew
Copy link
Member

Lgtm.

Something strange here in that this appears to be a clean backport but was not recognized as such by the bot.

I don't think the bot marks 8u backports as clean, due to the path shuffling. At least, I've not seen it happen so far.

@mrserb
Copy link
Member Author

mrserb commented Feb 11, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 11, 2023

Going to push as commit b71f59b.
Since your change was applied there have been 2 commits pushed to the master branch:

  • fbaabf3: 8301620: [8u] some shell tests are passed but have unexpected operator errors
  • 8c42e20: 8287109: Distrust.java failed with CertificateExpiredException

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 11, 2023
@openjdk openjdk bot closed this Feb 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 11, 2023
@openjdk
Copy link

openjdk bot commented Feb 11, 2023

@mrserb Pushed as commit b71f59b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants