Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275535: Retrying a failed authentication on multiple LDAP servers can lead to users blocked #268

Closed
wants to merge 1 commit into from

Conversation

alexeybakhtin
Copy link
Contributor

@alexeybakhtin alexeybakhtin commented Feb 16, 2023

Clean backport after the jdk8 path adjustment

This patch fixes the authentication issue introduced by https://bugs.openjdk.org/browse/JDK-8160768

javax/naming tests are passed


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8275535: Retrying a failed authentication on multiple LDAP servers can lead to users blocked

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/268/head:pull/268
$ git checkout pull/268

Update a local copy of the PR:
$ git checkout pull/268
$ git pull https://git.openjdk.org/jdk8u-dev pull/268/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 268

View PR using the GUI difftool:
$ git pr show -t 268

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/268.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 16, 2023

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3be394e1606dd17c2c14ce806c796f5eb2b1ad6e 8275535: Retrying a failed authentication on multiple LDAP servers can lead to users blocked Feb 16, 2023
@openjdk
Copy link

openjdk bot commented Feb 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 16, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 16, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean backport from 11u. Lgtm.

@openjdk
Copy link

openjdk bot commented Feb 16, 2023

@alexeybakhtin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8275535: Retrying a failed authentication on multiple LDAP servers can lead to users blocked

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • b3e2380: 8301143: [TESTBUG] jfr/event/sampling/TestNative was backported to JDK8u without proper native wrapper
  • aed31d9: 8270317: Large Allocation in CipherSuite

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 16, 2023
@alexeybakhtin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 17, 2023

Going to push as commit b51619d.
Since your change was applied there have been 3 commits pushed to the master branch:

  • ca0a6be: 8301246: NPE in FcFontManager.getDefaultPlatformFont() on Linux without installed fontconfig
  • b3e2380: 8301143: [TESTBUG] jfr/event/sampling/TestNative was backported to JDK8u without proper native wrapper
  • aed31d9: 8270317: Large Allocation in CipherSuite

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 17, 2023
@openjdk openjdk bot closed this Feb 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 17, 2023
@openjdk
Copy link

openjdk bot commented Feb 17, 2023

@alexeybakhtin Pushed as commit b51619d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants