Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277881: Missing SessionID in TLS1.3 resumption in compatibility mode #300

Closed
wants to merge 1 commit into from

Conversation

lutkerd
Copy link
Contributor

@lutkerd lutkerd commented Apr 10, 2023

Patch applied cleanly after updating file paths.

Backport to fix issue in TLSv1.3 Middleware compatibility and parity with Oracle 8u381. Passed Tier1/2 testing internally on Linux x64 and aarch64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277881: Missing SessionID in TLS1.3 resumption in compatibility mode

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/300/head:pull/300
$ git checkout pull/300

Update a local copy of the PR:
$ git checkout pull/300
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/300/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 300

View PR using the GUI difftool:
$ git pr show -t 300

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/300.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 10, 2023

👋 Welcome back lutkerd! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9d99a377bfb6ffa890db049aee575e97914fc2a1 8277881: Missing SessionID in TLS1.3 resumption in compatibility mode Apr 10, 2023
@openjdk
Copy link

openjdk bot commented Apr 10, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Apr 10, 2023
@lutkerd lutkerd marked this pull request as ready for review April 10, 2023 22:57
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 10, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 10, 2023

Webrevs

@phohensee
Copy link
Member

/clean

@openjdk openjdk bot added the clean label Apr 11, 2023
@openjdk
Copy link

openjdk bot commented Apr 11, 2023

@phohensee This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Apr 11, 2023

@lutkerd This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8277881: Missing SessionID in TLS1.3 resumption in compatibility mode

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 43561ef: 8151460: Metaspace counters can have inconsistent values
  • 721c0ee: 8305113: (tz) Update Timezone Data to 2023c
  • 4445e5c: 8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 11, 2023
@lutkerd
Copy link
Contributor Author

lutkerd commented Apr 19, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 19, 2023
@openjdk
Copy link

openjdk bot commented Apr 19, 2023

@lutkerd
Your change (at version d396244) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 19, 2023

Going to push as commit b94b568.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 43561ef: 8151460: Metaspace counters can have inconsistent values
  • 721c0ee: 8305113: (tz) Update Timezone Data to 2023c
  • 4445e5c: 8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 19, 2023
@openjdk openjdk bot closed this Apr 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 19, 2023
@openjdk
Copy link

openjdk bot commented Apr 19, 2023

@phohensee @lutkerd Pushed as commit b94b568.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants