Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8206179: com/sun/management/OperatingSystemMXBean/GetCommittedVirtualMemorySize.java fails with Committed virtual memory size illegal value #352

Closed
wants to merge 1 commit into from
Closed

8206179: com/sun/management/OperatingSystemMXBean/GetCommittedVirtualMemorySize.java fails with Committed virtual memory size illegal value #352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 4 additions & 15 deletions jdk/test/com/sun/management/OperatingSystemMXBean/GetCommittedVirtualMemorySize.java
View file
Open in desktop
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2003, 2004, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2003, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -56,8 +56,7 @@ public class GetCommittedVirtualMemorySize {

// Careful with these values.
private static final long MIN_SIZE_FOR_PASS = 1;
// Max size for pass dynamically determined below
private static long max_size_for_pass = Long.MAX_VALUE;
private static long MAX_SIZE_FOR_PASS = Long.MAX_VALUE;

private static boolean trace = false;

Expand All @@ -66,16 +65,6 @@ public static void main(String args[]) throws Exception {
trace = true;
}

// 4934082: On Linux, VM size *can* be larger than total swap
// size. Linux might not reserve swap memory immediately when
// a page is mmaped. This means that the reported committed
// memory size can grow beyond the swap limit.
long max_size = mbean.getTotalSwapSpaceSize() +
mbean.getTotalPhysicalMemorySize();

if (max_size > 0) {
max_size_for_pass = max_size;
}
long size = mbean.getCommittedVirtualMemorySize();
if (size == -1) {
System.out.println("getCommittedVirtualMemorySize() is not supported");
Expand All @@ -87,11 +76,11 @@ public static void main(String args[]) throws Exception {
size);
}

if (size < MIN_SIZE_FOR_PASS || size > max_size_for_pass) {
if (size < MIN_SIZE_FOR_PASS || size > MAX_SIZE_FOR_PASS) {
throw new RuntimeException("Committed virtual memory size " +
"illegal value: " + size + " bytes " +
"(MIN = " + MIN_SIZE_FOR_PASS + "; " +
"MAX = " + max_size_for_pass + ")");
"MAX = " + MAX_SIZE_FOR_PASS + ")");
}

System.out.println("Test passed.");
Expand Down