8233019: java.lang.Class.isPrimitive() (C1) returns wrong result if Klass* is aligned to 32bit

[dongbohe]

Hi,

I would like to backport this as follow up of JDK-8150669
This resolves the corner case that leads to incorrect result for C1 intrinsic,

Original patch for 11u: https://hg.openjdk.java.net/jdk-updates/jdk11u-dev/rev/e1b6631cbd2f
Patch does not apply cleanly to 8u: arm and s390 ports are not there and we don’t have c1 compiler support in ppc port in 8u.

Performed full jtreg test both on x86_64-linux-gnu and aarch64-linux-gnu platforms.
(I made this PR on behalf of fyang)

Thanks,
hedongbo

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8233019: java.lang.Class.isPrimitive() (C1) returns wrong result if Klass* is aligned to 32bit

Reviewers

• Paul Hohensee (@phohensee - Reviewer) ⚠️ Review applies to 5274a23f

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/43/head:pull/43
$ git checkout pull/43

Update a local copy of the PR:
$ git checkout pull/43
$ git pull https://git.openjdk.org/jdk8u-dev pull/43/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 43

View PR using the GUI difftool:
$ git pr show -t 43

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/43.diff

[bridgekeeper]

👋 Welcome back dongbohe! A progress list of the required criteria for merging this PR into pr/37 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 03: Full - Incremental (69b5b2f8)
• 02: Full (5274a23f)
• 01: Full - Incremental (0ac67b30)
• 00: Full (d1ef6921)

[bridgekeeper]

@dongbohe This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@dongbohe This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[dongbohe]

/open

[openjdk]

@dongbohe This pull request is now open

[openjdk]

⚠️ @dongbohe This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[openjdk-notifier]

@dongbohe Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

[phohensee]

Lgtm.

[openjdk-notifier]

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8233019
git fetch https://git.openjdk.org/jdk8u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@dongbohe This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8233019: java.lang.Class.isPrimitive() (C1) returns wrong result if Klass* is aligned to 32bit

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• e005185: 8235218: Minimal VM is broken after JDK-8173361

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[dongbohe]

Got the push approval.
/integrate

[openjdk]

@dongbohe
Your change (at version 69b5b2f) is now ready to be sponsored by a Committer.

[RealFYang]

/sponsor

[openjdk]

Going to push as commit 972112e.
Since your change was applied there has been 1 commit pushed to the master branch:

• e005185: 8235218: Minimal VM is broken after JDK-8173361

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang @dongbohe Pushed as commit 972112e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.