8071530: Update OS detection code to reflect Windows 10 version change

[rgithubli]

jdk commit: openjdk/jdk@fa47cc3

Clean backport.

Testing:

• Tested with this change applied: 8274840: Update OS detection code to recognize Windows 11 #93. This backport is a prerequisite of 8274840: Update OS detection code to recognize Windows 11 #93.
• Verified on win11: when doing java -XshowSettings:properties -version, can see os.name = Windows 11

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8071530: Update OS detection code to reflect Windows 10 version change

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/91/head:pull/91
$ git checkout pull/91

Update a local copy of the PR:
$ git checkout pull/91
$ git pull https://git.openjdk.org/jdk8u-dev pull/91/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 91

View PR using the GUI difftool:
$ git pr show -t 91

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/91.diff

[bridgekeeper]

Hi @rgithubli, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user rgithubli" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[rgithubli]

/covered

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[openjdk]

@rgithubli This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8071530: Update OS detection code to reflect Windows 10 version change

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• 0d5ea9d: 8292688: Support Security properties in security.testlibrary.Proc
• 026a6c5: 7131823: bug in GIFImageReader
• d102764: 8139668: Generate README-build.html from markdown
• de32daa: 8173339: AArch64: Fix minimum stack size computations
• 2223058: 8049228: Improve multithreaded scalability of InetAddress cache
• d0ad242: 8285497: Add system property for Java SE specification maintenance version
• e3251a2: 8232950: SUNPKCS11 Provider incorrectly check key length for PSS Signatures.
• 41c7d2d: 8039955: [TESTBUG] jdk/lambda/LambdaTranslationTest1 - java.lang.AssertionError: expected [d:1234.000000] but found [d:1234,000000]
• a4d4973: 8254318: Remove .hgtags
• 8ad9018: 8285400: Add '@APinote' to the APIs defined in Java SE 8 MR 3
• ... and 14 more: https://git.openjdk.org/jdk8u-dev/compare/f7f6d9d07fa3f166fe0155f80c61730c1c788ac5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (dbe5bee0)

[mrserb]

Please add a note on how it was tested.

[rgithubli]

Please add a note on how it was tested.

Updated the overview with manual test description. Also triggered a new Pre-submit action for the branch: https://github.com/rgithubli/jdk8u-dev/actions/workflows/submit.yml. Thanks.

[calderast]

@rgithubli are you still planning to integrate this PR and dependent PR #93? Can we get a fix-yes tag?

[rgithubli]

@calderast Yes I do plan to integrate. We're still waiting for maintainers to review and mark both JBS issues (JDK-8071530, JDK-8274840) to jdk8u-fix-request jdk8u-fix-yes. Any chance you know how to accelerate?

[calderast]

jdk8u maintainer @theRealAph, could you please review for a fix-yes? Thanks!

[phohensee]

I tagged JDK-8071530 and JDK-8274840 almost a month ago.

[jerboaa]

I tagged JDK-8071530 and JDK-8274840 almost a month ago.

Sorry, I've approved them both now.

[rgithubli]

@phohensee Yeah sorry. I meant fix-yes tag rather than fix-request. Fixed the comment. Thanks for helping out for the tagging!

@jerboaa Thanks!

[rgithubli]

/integrate

[openjdk]

@rgithubli
Your change (at version dbe5bee) is now ready to be sponsored by a Committer.

[jerboaa]

/sponsor

[openjdk]

Going to push as commit 266918d.
Since your change was applied there have been 24 commits pushed to the master branch:

• 0d5ea9d: 8292688: Support Security properties in security.testlibrary.Proc
• 026a6c5: 7131823: bug in GIFImageReader
• d102764: 8139668: Generate README-build.html from markdown
• de32daa: 8173339: AArch64: Fix minimum stack size computations
• 2223058: 8049228: Improve multithreaded scalability of InetAddress cache
• d0ad242: 8285497: Add system property for Java SE specification maintenance version
• e3251a2: 8232950: SUNPKCS11 Provider incorrectly check key length for PSS Signatures.
• 41c7d2d: 8039955: [TESTBUG] jdk/lambda/LambdaTranslationTest1 - java.lang.AssertionError: expected [d:1234.000000] but found [d:1234,000000]
• a4d4973: 8254318: Remove .hgtags
• 8ad9018: 8285400: Add '@APinote' to the APIs defined in Java SE 8 MR 3
• ... and 14 more: https://git.openjdk.org/jdk8u-dev/compare/f7f6d9d07fa3f166fe0155f80c61730c1c788ac5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa @rgithubli Pushed as commit 266918d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.