Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296715: CLDR v42 update for tzdata 2022f #27

Closed
wants to merge 1 commit into from

Conversation

gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Dec 20, 2022

This is a minimal backport of the CLDR v42 update for tzdata 2022f, just containing the timezone changes. The previous definition for America/Chihuahua, which is superseded by the change to America_Central on 2022-10-30, is retained as America_Mountain as Mexico_Pacific doesn't exist in 8u's version of CLDR and the change here is to define an end to that metazone, not alter it.

The other changes are omitted as follows:

  • The es_419.xml in 8u's CLDR does not contain the patterns being altered.
  • LocaleData.cldr does not exist in 8u
  • LocaleDataTest.java does not need updating as the test has not been changed, as there is no data file change (LocaleData.cldr)

Regarding the latter two, the CLDR checks in the test were introduced as part of JDK-8008577: "Use CLDR Locale Data by Default". We obviously don't want to backport that in full, but updating LocaleDataTest.java with a CLDR data set would be useful.

However, I think it's out of scope for a rampdown time critical data fix like this, as it is likely a lengthy effort to get a passing data set, needing further CLDR updates. It should be handled separately. I'll open a bug and PR for this against 8u-dev.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u pull/27/head:pull/27
$ git checkout pull/27

Update a local copy of the PR:
$ git checkout pull/27
$ git pull https://git.openjdk.org/jdk8u pull/27/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27

View PR using the GUI difftool:
$ git pr show -t 27

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/27.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2022

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport da9de488990ff47fe06343439f2180ec1b2a3061 8296715: CLDR v42 update for tzdata 2022f Dec 20, 2022
@openjdk
Copy link

openjdk bot commented Dec 20, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 20, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 20, 2022

Webrevs

Copy link
Contributor

@dimitryc dimitryc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Dec 21, 2022

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8296715: CLDR v42 update for tzdata 2022f

Reviewed-by: dcherepanov, sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 21, 2022
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@gnu-andrew
Copy link
Member Author

Thanks both. Flagged with jdk8u-critical-request.

@gnu-andrew
Copy link
Member Author

I see jdk8u-critical-yes.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 22, 2022

Going to push as commit 518047d.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 22, 2022
@openjdk openjdk bot closed this Dec 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 22, 2022
@openjdk
Copy link

openjdk bot commented Dec 22, 2022

@gnu-andrew Pushed as commit 518047d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants