Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903574: jextract should add lang=c to snippets containing C sources #136

Closed
wants to merge 4 commits into from

Conversation

wangweij
Copy link
Contributor

@wangweij wangweij commented Oct 22, 2023

Add lang=c to snippets.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (no review required)

Issue

  • CODETOOLS-7903574: jextract should add lang=c to snippets containing C sources (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jextract.git pull/136/head:pull/136
$ git checkout pull/136

Update a local copy of the PR:
$ git checkout pull/136
$ git pull https://git.openjdk.org/jextract.git pull/136/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 136

View PR using the GUI difftool:
$ git pr show -t 136

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jextract/pull/136.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 22, 2023

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into panama will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@wangweij wangweij closed this Oct 22, 2023
@openjdk
Copy link

openjdk bot commented Oct 22, 2023

@wangweij This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7903574: jextract should add lang=c to snippets containing C sources

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the panama branch:

  • 466fd8f: 7903573: Jextract does not support atomic types

Please see this link for an up-to-date comparison between the source branch of this pull request and the panama branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 22, 2023
@wangweij wangweij deleted the 7903574 branch October 22, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

None yet

3 participants