Skip to content

Commit 67ac9d7

Browse files
author
Hima Bindu Meda
committedAug 21, 2024
8338306: WebView Drag and Drop fails with WebKit 619.1
Reviewed-by: kcr, sykora
·
25+824+6
1 parent f1bac5a commit 67ac9d7

File tree

1 file changed

+3
-1
lines changed
  • modules/javafx.web/src/main/native/Source/WebKitLegacy/java/WebCoreSupport

1 file changed

+3
-1
lines changed
 

‎modules/javafx.web/src/main/native/Source/WebKitLegacy/java/WebCoreSupport/WebPage.cpp

+3-1
Original file line numberDiff line numberDiff line change
@@ -2250,8 +2250,10 @@ JNIEXPORT jint JNICALL Java_com_sun_webkit_WebPage_twkProcessDrag
22502250
case com_sun_webkit_WebPage_DND_DST_EXIT:
22512251
dc.dragExited(*localMainFrame,WTFMove(dragData));
22522252
return 0;
2253+
case com_sun_webkit_WebPage_DND_DST_ENTER:
22532254
case com_sun_webkit_WebPage_DND_DST_OVER:
2254-
2255+
case com_sun_webkit_WebPage_DND_DST_CHANGE:
2256+
return dragOperationToDragCursor(std::get<std::optional<WebCore::DragOperation>>(dc.dragEnteredOrUpdated(*localMainFrame, WTFMove(dragData))));
22552257
case com_sun_webkit_WebPage_DND_DST_DROP:
22562258
{
22572259
int ret = dc.performDragOperation(WTFMove(dragData)) ? 1 : 0;

7 commit comments

Comments
 (7)

openjdk-notifier[bot] commented on Aug 21, 2024

@openjdk-notifier[bot]
openjdk-notifier[bot]
on Aug 21, 2024

Review

Issues

HimaBinduMeda commented on Aug 22, 2024

@HimaBinduMeda
HimaBinduMeda
on Aug 22, 2024
Contributor

/backport jfx23u

openjdk[bot] commented on Aug 22, 2024

@openjdk[bot]
openjdk[bot]
on Aug 22, 2024

@HimaBinduMeda the backport was successfully created on the branch backport-HimaBinduMeda-67ac9d78-master in my personal fork of openjdk/jfx23u. To create a pull request with this backport targeting openjdk/jfx23u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 67ac9d78 from the openjdk/jfx repository.

The commit being backported was authored by Hima Bindu Meda on 21 Aug 2024 and was reviewed by Kevin Rushforth and Joeri Sykora.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jfx23u:

$ git fetch https://github.com/openjdk-bots/jfx23u.git backport-HimaBinduMeda-67ac9d78-master:backport-HimaBinduMeda-67ac9d78-master
$ git checkout backport-HimaBinduMeda-67ac9d78-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jfx23u.git backport-HimaBinduMeda-67ac9d78-master

johanvos commented on Nov 21, 2024

@johanvos
johanvos
on Nov 21, 2024
Collaborator

/backport jfx17u

johanvos commented on Nov 21, 2024

@johanvos
johanvos
on Nov 21, 2024
Collaborator

/backport jfx21u

openjdk[bot] commented on Nov 21, 2024

@openjdk[bot]
openjdk[bot]
on Nov 21, 2024

@johanvos the backport was successfully created on the branch backport-johanvos-67ac9d78-master in my personal fork of openjdk/jfx17u. To create a pull request with this backport targeting openjdk/jfx17u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 67ac9d78 from the openjdk/jfx repository.

The commit being backported was authored by Hima Bindu Meda on 21 Aug 2024 and was reviewed by Kevin Rushforth and Joeri Sykora.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jfx17u:

$ git fetch https://github.com/openjdk-bots/jfx17u.git backport-johanvos-67ac9d78-master:backport-johanvos-67ac9d78-master
$ git checkout backport-johanvos-67ac9d78-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jfx17u.git backport-johanvos-67ac9d78-master

openjdk[bot] commented on Nov 21, 2024

@openjdk[bot]
openjdk[bot]
on Nov 21, 2024

@johanvos the backport was successfully created on the branch backport-johanvos-67ac9d78-master in my personal fork of openjdk/jfx21u. To create a pull request with this backport targeting openjdk/jfx21u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 67ac9d78 from the openjdk/jfx repository.

The commit being backported was authored by Hima Bindu Meda on 21 Aug 2024 and was reviewed by Kevin Rushforth and Joeri Sykora.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jfx21u:

$ git fetch https://github.com/openjdk-bots/jfx21u.git backport-johanvos-67ac9d78-master:backport-johanvos-67ac9d78-master
$ git checkout backport-johanvos-67ac9d78-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jfx21u.git backport-johanvos-67ac9d78-master
Please sign in to comment.