8294400: Provide media support for libavcodec version 59

Reviewed-by: kcr, jvos

build.gradle

@@ -2855,6 +2855,7 @@ project(":media") {
             media name: "libav-12.1", ext: "tar.gz"
             media name: "ffmpeg-3.3.3", ext: "tar.gz"
             media name: "ffmpeg-4.0.2", ext: "tar.gz"
+            media name: "ffmpeg-5.1.2", ext: "tar.gz"
         }
         implementation project(":base")
         implementation project(":graphics")
@@ -3003,10 +3004,12 @@ project(":media") {
                 def copyLibAVStubs = {String fromDir, String toDir ->
                     FileCollection config = files("config.h")
                     FileCollection libavcodec = files("avcodec.h", "avfft.h", "dxva2.h", "vaapi.h", "vda.h",
-                                                      "vdpau.h", "version.h", "xvmc.h", "old_codec_ids.h")
+                                                      "vdpau.h", "version.h", "xvmc.h", "old_codec_ids.h",
+                                                      "codec.h", "codec_desc.h", "codec_par.h", "codec_id.h",
+                                                      "defs.h", "packet.h", "version_major.h")
                     FileCollection libavdevice = files("avdevice.h", "version.h")
                     FileCollection libavfilter = files("avfiltergraph.h", "avfilter.h", "buffersink.h", "buffersrc.h", "version.h");
-                    FileCollection libavformat = files("avformat.h", "avio.h", "version.h")
+                    FileCollection libavformat = files("avformat.h", "avio.h", "version.h", "version_major.h")
                     FileCollection libavresample = files("avresample.h", "version.h")
                     FileCollection libavutil = files("adler32.h", "blowfish.h", "error.h", "log.h", "pixfmt.h",
                                                      "aes.h", "bswap.h", "eval.h", "lzo.h", "random_seed.h",
@@ -3019,7 +3022,7 @@ project(":media") {
                                                      "dict.h", "lfg.h", "pixdesc.h", "intfloat_readwrite.h", "old_pix_fmts.h", "audioconvert.h",
                                                      "cpu.h", "hwcontext.h")
                     FileCollection libavutil_x86 = files("cpu.h") // Use cpu.h from x86 instead of libavutil root if exist
-                    FileCollection libswscale = files("swscale.h", "version.h")
+                    FileCollection libswscale = files("swscale.h", "version.h", "version_major.h")
 
                     def copyLibAVFiles = {FileCollection files, String fDir, String tDir ->
                         File dir = file(tDir)
@@ -3199,8 +3202,8 @@ project(":media") {
                     doLast {
                         project.ext.libav = [:]
                         project.ext.libav.basedir = "${buildDir}/native/linux/ffmpeg"
-                        project.ext.libav.versions = [ "3.3.3", "4.0.2" ]
-                        project.ext.libav.versionmap = [ "3.3.3" : "57", "4.0.2" : "58" ]
+                        project.ext.libav.versions = [ "3.3.3", "4.0.2", "5.1.2" ]
+                        project.ext.libav.versionmap = [ "3.3.3" : "57", "4.0.2" : "58", "5.1.2" : "59" ]
 
                         libav.versions.each { version ->
                             def libavDir = "${libav.basedir}/ffmpeg-${version}"
@@ -3280,7 +3283,7 @@ project(":media") {
                             project.ext.libav.libavffmpeg.versions = [ "56" ]
                             project.ext.libav.ffmpeg = [:]
                             project.ext.libav.ffmpeg.basedir = "${buildDir}/native/linux/ffmpeg/ffmpeg"
-                            project.ext.libav.ffmpeg.versions = [ "57", "58" ]
+                            project.ext.libav.ffmpeg.versions = [ "57", "58", "59" ]
 
                             project.ext.libav.versions.each { version ->
                                 def libavDir = "${project.ext.libav.basedir}-${version}"

gradle/verification-metadata.xml

@@ -18,6 +18,11 @@
             <sha256 value="a56ef203c14ffab56b97690a1005522cfa0dc2c42c3c40c33c0bec4875b706eb" origin="Generated by Gradle"/>
          </artifact>
       </component>
+      <component group="" name="ffmpeg-5.1.2" version="">
+         <artifact name="ffmpeg-5.1.2-.tar.gz">
+            <sha256 value="87fe8defa37ce5f7449e36047171fed5e4c3f4bb73eaccea8c954ee81393581c" origin="Generated by Gradle"/>
+         </artifact>
+      </component>
       <component group="" name="icu4c-71_1-data-bin-l" version="">
          <artifact name="icu4c-71_1-data-bin-l-.zip">
             <sha256 value="a55588cb4064202b2d840e66c6147d48940795e30d9da11c1a5fc068b8b9a993" origin="Generated by Gradle"/>

modules/javafx.media/src/main/java/com/sun/media/jfxmediaimpl/NativeMediaManager.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010, 2021, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2010, 2022, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -125,6 +125,7 @@ protected NativeMediaManager() {
                     dependencies.add("avplugin-ffmpeg-56");
                     dependencies.add("avplugin-ffmpeg-57");
                     dependencies.add("avplugin-ffmpeg-58");
+                    dependencies.add("avplugin-ffmpeg-59");
                 }
                 if (HostUtils.isMacOSX()) {
                     dependencies.add("fxplugins");

modules/javafx.media/src/main/native/gstreamer/gstreamer-lite/gstreamer/gst/gstregistry.c

@@ -146,7 +146,7 @@ static const int AVCODEC_LIBAV_EXPLICIT_VERSIONS[] = { 54, 56 };
 // For ffmpeg (libavcodec-ffmpeg.so)
 static const int AVCODEC_FFMPEG_EXPLICIT_VERSIONS[] = { 56 };
 // For libav or ffmpeg (libavcodec.so)
-static const int AVCODEC_EXPLICIT_VERSIONS[] = { 57, 58 };
+static const int AVCODEC_EXPLICIT_VERSIONS[] = { 57, 58, 59 };
 
 /*
  * Callback passed to dl_iterate_phdr(): finds the path of

modules/javafx.media/src/main/native/gstreamer/plugins/av/audiodecoder.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010, 2021, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2010, 2022, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -124,7 +124,7 @@ static gboolean audiodecoder_init_state(AudioDecoder *decoder);
 static gboolean audiodecoder_open_init(AudioDecoder *decoder, GstCaps* caps);
 static gboolean audiodecoder_src_event(GstPad* pad, GstObject *parent, GstEvent* event);
 
-#if DECODE_AUDIO4
+#if DECODE_AUDIO4 || USE_SEND_RECEIVE
 static gboolean audiodecoder_is_oformat_supported(int format);
 #endif
 
@@ -190,7 +190,7 @@ static gboolean audiodecoder_init_state(AudioDecoder *decoder)
     decoder->codec_id = CODEC_ID_NONE;
 #endif
 
-#if !DECODE_AUDIO4
+#if !DECODE_AUDIO4 && !USE_SEND_RECEIVE
     decoder->samples = av_mallocz(AVCODEC_MAX_AUDIO_FRAME_SIZE + FF_INPUT_BUFFER_PADDING_SIZE);
     if (!decoder->samples)
         return FALSE;
@@ -225,7 +225,7 @@ static void audiodecoder_state_reset(AudioDecoder *decoder)
 
 static void audiodecoder_close_decoder(AudioDecoder *decoder)
 {
-#if !DECODE_AUDIO4
+#if !DECODE_AUDIO4 && !USE_SEND_RECEIVE
     if (decoder->samples)
     {
         av_free(decoder->samples);
@@ -649,7 +649,7 @@ static GstFlowReturn audiodecoder_chain(GstPad *pad, GstObject *parent, GstBuffe
     GstMapInfo    info2;
     gboolean      unmap_buf = FALSE;
 
-#if DECODE_AUDIO4
+#if DECODE_AUDIO4 || USE_SEND_RECEIVE
     gint          got_frame = 0;
     int           sample, ci;
  #else
@@ -712,14 +712,24 @@ static GstFlowReturn audiodecoder_chain(GstPad *pad, GstObject *parent, GstBuffe
     decoder->packet.data = info.data;
     decoder->packet.size = info.size;
 
-#if DECODE_AUDIO4
+#if USE_SEND_RECEIVE
+    num_dec = avcodec_send_packet(base->context, &decoder->packet);
+    if (num_dec == 0)
+    {
+        num_dec = avcodec_receive_frame(base->context, base->frame);
+        if (num_dec == 0)
+        {
+            got_frame = 1;
+        }
+    }
+#elif DECODE_AUDIO4
     num_dec = avcodec_decode_audio4(base->context, base->frame, &got_frame, &decoder->packet);
 #else
     num_dec = avcodec_decode_audio3(base->context, (int16_t*)decoder->samples, &outbuf_size, &decoder->packet);
 #endif
 
 
-#if DECODE_AUDIO4
+#if DECODE_AUDIO4 || USE_SEND_RECEIVE
     if (num_dec < 0 || !got_frame)
 #else
     if (num_dec < 0 || outbuf_size == 0)
@@ -732,7 +742,7 @@ static GstFlowReturn audiodecoder_chain(GstPad *pad, GstObject *parent, GstBuffe
     }
 
     GstBuffer *outbuf = NULL;
-#if DECODE_AUDIO4
+#if DECODE_AUDIO4 || USE_SEND_RECEIVE
     if (!audiodecoder_is_oformat_supported(base->frame->format))
     {
         gst_element_message_full(GST_ELEMENT(decoder), GST_MESSAGE_ERROR, GST_CORE_ERROR, GST_CORE_ERROR_NOT_IMPLEMENTED,
@@ -767,7 +777,7 @@ static GstFlowReturn audiodecoder_chain(GstPad *pad, GstObject *parent, GstBuffe
         goto _exit;
     }
 
-#if DECODE_AUDIO4
+#if DECODE_AUDIO4 || USE_SEND_RECEIVE
     if (base->frame->format == AV_SAMPLE_FMT_S16P || base->frame->format == AV_SAMPLE_FMT_FLTP)
     {
         // Make sure we received expected data
@@ -876,7 +886,7 @@ static GstFlowReturn audiodecoder_chain(GstPad *pad, GstObject *parent, GstBuffe
     return ret;
 }
 
-#if DECODE_AUDIO4
+#if DECODE_AUDIO4 || USE_SEND_RECEIVE
 static gboolean audiodecoder_is_oformat_supported(int format)
 {
     return (format == AV_SAMPLE_FMT_S16P || format == AV_SAMPLE_FMT_FLTP ||

modules/javafx.media/src/main/native/gstreamer/plugins/av/audiodecoder.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010, 2014, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2010, 2022, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -53,7 +53,7 @@ typedef struct _AudioDecoderClass AudioDecoderClass;
 struct _AudioDecoder {
     BaseDecoder  parent;
 
-#if !DECODE_AUDIO4
+#if !DECODE_AUDIO4 && !USE_SEND_RECEIVE
     guint8       *samples;          // temporary output buffer
 #endif
 

modules/javafx.media/src/main/native/gstreamer/plugins/av/avdefines.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010, 2021, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2010, 2022, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -27,8 +27,8 @@
 #define AVDEFINES_H
 
 // According to ffmpeg Git they introduced
-// _decode_audio4  in version 53.25.0
-#define DECODE_AUDIO4          (LIBAVCODEC_VERSION_INT >= AV_VERSION_INT(53,25,0))
+// _decode_audio4 in version 53.25.0 and removed in version 59
+#define DECODE_AUDIO4          (LIBAVCODEC_VERSION_INT >= AV_VERSION_INT(53,25,0) && LIBAVCODEC_VERSION_INT < AV_VERSION_INT(59,0,0))
 
 // New AVCodecID was introduced in 54.25.0
 #define NEW_CODEC_ID           (LIBAVCODEC_VERSION_INT >= AV_VERSION_INT(54,25,0))
@@ -39,5 +39,19 @@
 // HEVC/H.265 support should be available in 56 and up
 #define HEVC_SUPPORT           (LIBAVCODEC_VERSION_INT >= AV_VERSION_INT(56,0,0))
 
+// "codec" field was removed from AVStream in 59 and "codecpar" should be used
+// instead.
+#define CODEC_PAR              (LIBAVCODEC_VERSION_INT >= AV_VERSION_INT(59,0,0))
+
+// Use "av_packet_unref()"
+#define PACKET_UNREF           (LIBAVCODEC_VERSION_INT >= AV_VERSION_INT(59,0,0))
+
+// Use "avcodec_send_packet()" and "avcodec_receive_frame()"
+#define USE_SEND_RECEIVE       (LIBAVCODEC_VERSION_INT >= AV_VERSION_INT(59,0,0))
+
+// Do not call avcodec_register_all() and av_register_all()
+// Not required since 58 and removed in 59
+#define NO_REGISTER_ALL        (LIBAVCODEC_VERSION_INT >= AV_VERSION_INT(59,0,0))
+
 #endif  /* AVDEFINES_H */
 

modules/javafx.media/src/main/native/gstreamer/plugins/av/decoder.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010, 2015, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2010, 2022, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -23,6 +23,7 @@
  * questions.
  */
 
+#include <stdio.h>
 #include "decoder.h"
 #include <libavutil/mem.h>
 
@@ -76,7 +77,9 @@ static void basedecoder_init(BaseDecoder *self)
 
 static void basedecoder_class_init(BaseDecoderClass *g_class)
 {
+#if !NO_REGISTER_ALL
     avcodec_register_all();
+#endif
 
     g_class->init_context = basedecoder_init_context_default;
 }
@@ -104,8 +107,9 @@ gboolean basedecoder_open_decoder(BaseDecoder *decoder, CodecIDType id)
 #else
     decoder->frame = avcodec_alloc_frame();
 #endif
-    if (!decoder->frame)
+    if (!decoder->frame) {
         return FALSE; // Can't create frame
+    }
 
     G_LOCK(avlib_lock);