8237505: RadioMenuItem in ToggleGroup: deselected on accelerator #1002

karthikpandelu · 2023-01-19T12:54:55Z

No check was present in RadioMenuItem accelerator to see if it is in a ToggleGroup or not.

Made changes to check if RadioMenuItem is part of ToggleGroup or not. If it is part of a ToggleGroup, then it can not be cleared using accelerator.

Added test to validate the change.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8237505: RadioMenuItem in ToggleGroup: deselected on accelerator

Reviewers

Andy Goryachev (@andy-goryachev-oracle - Committer)
Ajit Ghaisas (@aghaisas - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/1002/head:pull/1002
$ git checkout pull/1002

Update a local copy of the PR:
$ git checkout pull/1002
$ git pull https://git.openjdk.org/jfx pull/1002/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1002

View PR using the GUI difftool:
$ git pr show -t 1002

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1002.diff

bridgekeeper · 2023-01-19T12:55:43Z

👋 Welcome back kpk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

mlbridge · 2023-01-19T13:00:47Z

Webrevs

01: Full - Incremental (42e8c397)
00: Full (b124c24e)

andy-goryachev-oracle · 2023-01-20T19:11:13Z

This looks good, given the decision to not to allow deselection by an accelerator.

But I wonder if the right approach is to have a property in the ToggleGroup which determines whether to allow all items to be deselected. If set, the radio menu items should be allowed to be deselected by both keyboard and mouse; if not set, the first item added to a group should be automatically selected, and radio menu items would not get deselected by the mouse or keyboard.

I think it might qualify as a separate enhancement (and a welcome one, since it saves some boilerplate code).

andy-goryachev-oracle

Tested with the MonkeyTester app.

I'd like to have a discussion on a new ToggleGroup's property (i'll send an email to the mailing list).

andy-goryachev-oracle · 2023-01-20T19:06:32Z

...es/javafx.controls/src/main/java/com/sun/javafx/scene/control/ControlAcceleratorSupport.java

@@ -175,7 +175,12 @@ private static void doAcceleratorInstall(final List<? extends MenuItem> items, f
                        }
                        if (!menuitem.isDisable()) {
                            if (menuitem instanceof RadioMenuItem) {
-                                ((RadioMenuItem)menuitem).setSelected(!((RadioMenuItem)menuitem).isSelected());
+                                if(((RadioMenuItem)menuitem).getToggleGroup() == null){


minor: this group insists on adding spaces after "if" and before "{"

You can use a pattern variable here to get rid of all the casts.

Updated the code to address above comments

karthikpandelu · 2023-01-23T08:27:25Z

Tested with the MonkeyTester app.

I'd like to have a discussion on a new ToggleGroup's property (i'll send an email to the mailing list).

I saw the mail chain sent out for this discussion. I agree that if any changes required as a result of this discussion can be taken as separate enhancement as you mentioned in the previous comment.

andy-goryachev-oracle

lgtm

aghaisas

The fix looks good to me!

openjdk · 2023-01-25T11:20:53Z

@karthikpandelu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8237505: RadioMenuItem in ToggleGroup: deselected on accelerator

Reviewed-by: angorya, aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

e710b55: Merge
05a67df: 8300664: Missing copyright header in ConditionalBinding.java file
294e82e: 8275033: Drag and drop a file produces NullPointerException Cannot read field "dragboard"
be89e3e: 8137244: Empty Tree/TableView with CONSTRAINED_RESIZE_POLICY is not properly resized
89219b7: Merge
1ccb586: Merge
5a70e4f: 8299628: BMP top-down images fail to load after JDK-8289336
98cff2f: Merge
d4f89d8: Merge
328bc40: Merge
... and 8 more: https://git.openjdk.org/jfx/compare/23004367dbe18ca9d6747b571744a3d4ab2c13c8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@andy-goryachev-oracle, @aghaisas) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

karthikpandelu · 2023-01-25T11:44:38Z

/integrate

openjdk · 2023-01-25T11:46:18Z

@karthikpandelu
Your change (at version 42e8c39) is now ready to be sponsored by a Committer.

karthikpandelu · 2023-01-25T11:52:23Z

@aghaisas please sponsor the PR.

aghaisas · 2023-01-25T11:56:56Z

/sponsor

openjdk · 2023-01-25T11:58:20Z

Going to push as commit e234c89.
Since your change was applied there have been 18 commits pushed to the master branch:

e710b55: Merge
05a67df: 8300664: Missing copyright header in ConditionalBinding.java file
294e82e: 8275033: Drag and drop a file produces NullPointerException Cannot read field "dragboard"
be89e3e: 8137244: Empty Tree/TableView with CONSTRAINED_RESIZE_POLICY is not properly resized
89219b7: Merge
1ccb586: Merge
5a70e4f: 8299628: BMP top-down images fail to load after JDK-8289336
98cff2f: Merge
d4f89d8: Merge
328bc40: Merge
... and 8 more: https://git.openjdk.org/jfx/compare/23004367dbe18ca9d6747b571744a3d4ab2c13c8...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-01-25T11:58:51Z

@aghaisas @karthikpandelu Pushed as commit e234c89.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Fix RadioMenuItem in ToggleGroup deselection on Accelerator issue

b124c24

openjdk bot added the rfr Ready for review label Jan 19, 2023

andy-goryachev-oracle approved these changes Jan 20, 2023

View reviewed changes

Address review comments

42e8c39

andy-goryachev-oracle approved these changes Jan 23, 2023

View reviewed changes

aghaisas approved these changes Jan 25, 2023

View reviewed changes

openjdk bot added the ready Ready to be integrated label Jan 25, 2023

openjdk bot added the sponsor Ready to sponsor label Jan 25, 2023

openjdk bot added the integrated Pull request has been integrated label Jan 25, 2023

openjdk bot closed this Jan 25, 2023

openjdk bot removed ready Ready to be integrated rfr Ready for review sponsor Ready to sponsor labels Jan 25, 2023

karthikpandelu deleted the radiomenu_issue_fix branch January 30, 2023 06:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8237505: RadioMenuItem in ToggleGroup: deselected on accelerator #1002

8237505: RadioMenuItem in ToggleGroup: deselected on accelerator #1002

karthikpandelu commented Jan 19, 2023 •

edited by openjdk bot

bridgekeeper bot commented Jan 19, 2023

mlbridge bot commented Jan 19, 2023 •

edited

andy-goryachev-oracle commented Jan 20, 2023

andy-goryachev-oracle left a comment

andy-goryachev-oracle Jan 20, 2023

mstr2 Jan 21, 2023

karthikpandelu Jan 23, 2023

karthikpandelu commented Jan 23, 2023

andy-goryachev-oracle left a comment

aghaisas left a comment

openjdk bot commented Jan 25, 2023

karthikpandelu commented Jan 25, 2023

openjdk bot commented Jan 25, 2023

karthikpandelu commented Jan 25, 2023

aghaisas commented Jan 25, 2023

openjdk bot commented Jan 25, 2023

openjdk bot commented Jan 25, 2023

8237505: RadioMenuItem in ToggleGroup: deselected on accelerator #1002

8237505: RadioMenuItem in ToggleGroup: deselected on accelerator #1002

Conversation

karthikpandelu commented Jan 19, 2023 • edited by openjdk bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Jan 19, 2023

mlbridge bot commented Jan 19, 2023 • edited

Webrevs

andy-goryachev-oracle commented Jan 20, 2023

andy-goryachev-oracle left a comment

Choose a reason for hiding this comment

andy-goryachev-oracle Jan 20, 2023

Choose a reason for hiding this comment

mstr2 Jan 21, 2023

Choose a reason for hiding this comment

karthikpandelu Jan 23, 2023

Choose a reason for hiding this comment

karthikpandelu commented Jan 23, 2023

andy-goryachev-oracle left a comment

Choose a reason for hiding this comment

aghaisas left a comment

Choose a reason for hiding this comment

openjdk bot commented Jan 25, 2023

karthikpandelu commented Jan 25, 2023

openjdk bot commented Jan 25, 2023

karthikpandelu commented Jan 25, 2023

aghaisas commented Jan 25, 2023

openjdk bot commented Jan 25, 2023

openjdk bot commented Jan 25, 2023

karthikpandelu commented Jan 19, 2023 •

edited by openjdk bot

mlbridge bot commented Jan 19, 2023 •

edited