Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8300664 Missing copyright header in ConditionalBinding.java file #1007

Closed
wants to merge 1 commit into from

Conversation

hjohn
Copy link
Collaborator

@hjohn hjohn commented Jan 21, 2023

Added a copyright header.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8300664: Missing copyright header in ConditionalBinding.java file

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/1007/head:pull/1007
$ git checkout pull/1007

Update a local copy of the PR:
$ git checkout pull/1007
$ git pull https://git.openjdk.org/jfx pull/1007/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1007

View PR using the GUI difftool:
$ git pr show -t 1007

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1007.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 21, 2023

👋 Welcome back jhendrikx! A progress list of the required criteria for merging this PR into jfx20 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Jan 21, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 21, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 21, 2023

@hjohn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300664: Missing copyright header in ConditionalBinding.java file

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jfx20 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Ready to be integrated label Jan 21, 2023
@hjohn
Copy link
Collaborator Author

hjohn commented Jan 21, 2023

/integrate

@openjdk openjdk bot added the sponsor Ready to sponsor label Jan 21, 2023
@openjdk
Copy link

openjdk bot commented Jan 21, 2023

@hjohn
Your change (at version 32fc90d) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 21, 2023

Going to push as commit 05a67df.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 21, 2023
@openjdk openjdk bot closed this Jan 21, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review sponsor Ready to sponsor labels Jan 21, 2023
@openjdk
Copy link

openjdk bot commented Jan 21, 2023

@kevinrushforth @hjohn Pushed as commit 05a67df.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants