JDK-8304705 Parent class contains 6 constants that should be static

[hjohn]

Made 6 constants static in Parent. Discovered these with the Java Object Layout tool.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8304705: Parent class contains 6 constants that should be static

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1064/head:pull/1064
$ git checkout pull/1064

Update a local copy of the PR:
$ git checkout pull/1064
$ git pull https://git.openjdk.org/jfx.git pull/1064/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1064

View PR using the GUI difftool:
$ git pr show -t 1064

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1064.diff

[bridgekeeper]

👋 Welcome back jhendrikx! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (258ea673)

[kevinrushforth]

Looks good. This seems like an obvious oversight.

[openjdk]

@hjohn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304705: Parent class contains 6 constants that should be static

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

• d875c87: 8304665: Change to Xcode12.4+1.1 devkit
• 0ab54e2: 8154038: Spinner's converter should update its editor
• b1964d9: Merge
• f2118a1: 8304359: Create release notes for JavaFX 20
• 6be8703: 8303680: Virtual Flow freezes after calling scrollTo and scrollPixels in succession
• 935c7b7: 8301009: Update libxml2 to 2.10.3
• 147d71f: 8178368: Right alignment of text fields and alignment of prompt text works incorrectly
• 4051f16: 8299968: Second call to Stage.setScene() create sizing issue with uiScale > 1.0
• df22c41: 8302355: Public API for Toolkit.canStartNestedEventLoop()
• 8cda7bc: 8302797: ArrayIndexOutOfBoundsException in TextRun.getWrapIndex()
• ... and 20 more: https://git.openjdk.org/jfx/compare/d1572f40b0cf65a34d30963c0b93b79c9ab91a8c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[hjohn]

/integrate

[openjdk]

Going to push as commit 85e529d.
Since your change was applied there have been 30 commits pushed to the master branch:

• d875c87: 8304665: Change to Xcode12.4+1.1 devkit
• 0ab54e2: 8154038: Spinner's converter should update its editor
• b1964d9: Merge
• f2118a1: 8304359: Create release notes for JavaFX 20
• 6be8703: 8303680: Virtual Flow freezes after calling scrollTo and scrollPixels in succession
• 935c7b7: 8301009: Update libxml2 to 2.10.3
• 147d71f: 8178368: Right alignment of text fields and alignment of prompt text works incorrectly
• 4051f16: 8299968: Second call to Stage.setScene() create sizing issue with uiScale > 1.0
• df22c41: 8302355: Public API for Toolkit.canStartNestedEventLoop()
• 8cda7bc: 8302797: ArrayIndexOutOfBoundsException in TextRun.getWrapIndex()
• ... and 20 more: https://git.openjdk.org/jfx/compare/d1572f40b0cf65a34d30963c0b93b79c9ab91a8c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@hjohn Pushed as commit 85e529d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.