Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8091153: Customize the Table Button Menu #1135

Closed
wants to merge 5 commits into from
+112 −14
Closed

8091153: Customize the Table Button Menu #1135

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8fd5c71
JDK-8091153: Implement ability to override and therefore customize th…
Maran23 May 13, 2023
aadbb43
JDK-8091153: Improve javadoc to match the CSR
Maran23 May 15, 2023
86f854f
JDK-8091153: Improve javadoc
Maran23 May 17, 2023
1752047
JDK-8091153: Added period to @implNote
Maran23 May 17, 2023
64c2df2
JDK-8091153: Replace @link with @code
Maran23 May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableHeaderRow.java
View file
Original file line number Diff line number Diff line change
@@ -465,11 +465,12 @@ protected NestedTableColumnHeader createRootHeader() {
}

/**
* Shows a menu with all leaf columns.
* These can selected/deselected to make the corresponding column visible/invisible.
* This method can be overridden if there is a desire to create and show a custom menu.
* Shows a menu containing all leaf columns as item.
* An item can be selected/deselected to make the corresponding column visible/invisible.
*
* @param mouseEvent the {@link MouseEvent} which was generated when the corner region was pressed.
* @implNote This method can be overridden to create and show a custom menu.
* @param mouseEvent the {@link MouseEvent} which was generated when the table menu button was pressed.
* @since 21
*/
protected void showColumnMenu(MouseEvent mouseEvent) {
if (columnPopupMenu == null) {