Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347392: Thread-unsafe implementation of c.s.j.scene.control.skin.Utils #1691

Closed
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
40857f5
initial test
andy-goryachev-oracle Jan 29, 2025
4539e56
more tests
andy-goryachev-oracle Jan 30, 2025
aba8476
all controls
andy-goryachev-oracle Jan 30, 2025
e9259a7
thread count
andy-goryachev-oracle Jan 30, 2025
02f3272
pagination
andy-goryachev-oracle Jan 30, 2025
8786bab
cleanup
andy-goryachev-oracle Jan 30, 2025
f6dd740
Merge branch 'master' into 8347392.thread.safe.utils
andy-goryachev-oracle Jan 30, 2025
5a219f9
8347392: Thread-unsafe implementation of c.s.j.scene.control.skin.Utils
andy-goryachev-oracle Jan 30, 2025
d1356dc
review comments
andy-goryachev-oracle Jan 31, 2025
e0b3033
fast loop
andy-goryachev-oracle Jan 31, 2025
3fde513
better name
andy-goryachev-oracle Jan 31, 2025
a05d391
jiggler
andy-goryachev-oracle Feb 3, 2025
e25f6f6
skip tests
andy-goryachev-oracle Feb 3, 2025
597e39d
Merge remote-tracking branch 'origin/master' into 8348423.node.thread…
andy-goryachev-oracle Feb 3, 2025
0c45ab9
Merge branch '8348423.node.thread.safety' into 8347392.thread.safe.utils
andy-goryachev-oracle Feb 3, 2025
0bf20d7
disabled titled pane test
andy-goryachev-oracle Feb 3, 2025
30700a6
more jitter
andy-goryachev-oracle Feb 3, 2025
ea306ab
Merge branch '8348423.node.thread.safety' into 8347392.thread.safe.utils
andy-goryachev-oracle Feb 3, 2025
42b7d8b
Merge remote-tracking branch 'origin/master' into 8348423.node.thread…
andy-goryachev-oracle Feb 5, 2025
0078aa1
review comments
andy-goryachev-oracle Feb 5, 2025
e1d0908
Merge branch '8348423.node.thread.safety' into 8347392.thread.safe.utils
andy-goryachev-oracle Feb 5, 2025
203f8de
Merge remote-tracking branch 'origin/master' into 8347392.thread.safe…
andy-goryachev-oracle Feb 5, 2025
1e9cb5d
review comments
andy-goryachev-oracle Feb 7, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -226,7 +226,7 @@ public void button() {
accessControl(c);
c.setAlignment(Pos.CENTER);
c.setText(nextString());
c.setDefaultButton(true);
c.setDefaultButton(nextBoolean());
});
}

@@ -253,8 +253,8 @@ public void checkBox() {
c.setSkin(new CheckBoxSkin(c));
return c;
}, (c) -> {
c.setAllowIndeterminate(true);
c.setSelected(true);
c.setAllowIndeterminate(nextBoolean());
c.setSelected(nextBoolean());
accessControl(c);
});
}
@@ -267,8 +267,8 @@ public void choiceBox() {
c.setSkin(new ChoiceBoxSkin(c));
return c;
}, (c) -> {
c.getItems().setAll("ChoiceBox", "1", "2");
c.getSelectionModel().select(0);
c.getItems().setAll("ChoiceBox", "1", "2", "3");
c.getSelectionModel().select(nextInt(4));
accessControl(c);
});
}
@@ -334,7 +334,7 @@ public void hyperlink() {
c.setSkin(new HyperlinkSkin(c));
return c;
}, (c) -> {
c.setVisited(true);
c.setVisited(nextBoolean());
accessControl(c);
});
}
@@ -595,6 +595,7 @@ public void textArea() {
return c;
}, (c) -> {
accessTextInputControl(c);
c.setWrapText(nextBoolean());
});
}