-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8351733: Crash when creating too many nested event loops #1741
Closed
+78
−2
Closed
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d975f09
Mac nows throws exception before we hit the limit on nested CFRunLoop…
beldenfox a28ea17
Moved some asserts so they're not inside runLater blocks.
beldenfox 02913fe
Merge remote-tracking branch 'upstream/master' into toomanyloops
beldenfox 49a21b4
Added explanation for limit on nested run loop calls
beldenfox 0d44f21
Lower limit on run loop nesting
beldenfox da1ce2d
The max nested event loop limit is now platform-independent
beldenfox b08594f
Set limit on nested event loop count to 200 which seems less arbitrary
beldenfox ee1fcac
The max nested event loop constant is no longer public
beldenfox 3ae07ff
Removed unnecessary import
beldenfox 99d2878
Now throwing an IllegalStateException
beldenfox 74b8034
Added description of the new nested event loop limit.
beldenfox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1