8289606: CustomSecurityManagerTest fails on Mac M1

[andy-goryachev-oracle]

• sampling at 1/3 of screen height instead of the very top to avoid hitting OS UI found on the newer Macs with a notch
• change applies to all platforms

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8289606: CustomSecurityManagerTest fails on Mac M1

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/826/head:pull/826
$ git checkout pull/826

Update a local copy of the PR:
$ git checkout pull/826
$ git pull https://git.openjdk.org/jfx pull/826/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 826

View PR using the GUI difftool:
$ git pr show -t 826

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/826.diff

[bridgekeeper]

👋 Welcome back andy-goryachev-oracle! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (d0bc6b1b)

[kevinrushforth]

Given what this test is trying to test, the proposed fix seems fine. I confirm that this test fails on my Mac M1 without the fix and passes with the fix.

One thing I just spotted is that this test makes the same mistake as `MouseLocationOnScreenTest -- see JDK-8289611 -- in that it uses the bounds rather than the visual bounds of the screen. You can either look into that as well, or leave it as a fix for another day.

[openjdk]

@andy-goryachev-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289606: CustomSecurityManagerTest fails on Mac M1

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[andy-goryachev-oracle]

/integrate

[openjdk]

@andy-goryachev-oracle
Your change (at version d0bc6b1) is now ready to be sponsored by a Committer.

[kevinrushforth]

/sponsor

[openjdk]

Going to push as commit eb8e9ef.

[openjdk]

@kevinrushforth @andy-goryachev-oracle Pushed as commit eb8e9ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.