8285881: Update WebKit to 614.1

[HimaBinduMeda]

Update JavaFX WebKit to GTK WebKit 2.36 (614.1).

Verified the updated version build, sanity tests and stability.
This does not cause any issues except a few unit test failures.
These tests are recorded and ignored using below bugs:
JDK-8290237
JDK-8290238
JDK-8290292

/contributor add jbhaskar
/contributor add arapte
/contributor add kcr

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (3 reviews required, with at least 1 Reviewer, 2 Authors)

Issue

• JDK-8285881: Update WebKit to 614.1

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)
• Ambarish Rapte (@arapte - Reviewer)
• Michael Strauß (@mstr2 - Author)
• Johan Vos (@johanvos - Reviewer)

Contributors

• Ambarish Rapte <arapte@openjdk.org>
• Kevin Rushforth <kcr@openjdk.org>
• Jay Bhaskar <jbhaskar@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/846/head:pull/846
$ git checkout pull/846

Update a local copy of the PR:
$ git checkout pull/846
$ git pull https://git.openjdk.org/jfx pull/846/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 846

View PR using the GUI difftool:
$ git pr show -t 846

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/846.diff

[bridgekeeper]

👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[kevinrushforth]

/reviewers 3

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 3 (with at least 1 Reviewer, 2 Authors).

[mlbridge]

Webrevs

• 00: Full (ef9e8140)

[openjdk]

@HimaBinduMeda Unknown command contibutor - for a list of valid commands use /help.

[openjdk]

@HimaBinduMeda
Contributor Ambarish Rapte <arapte@openjdk.org> successfully added.

[openjdk]

@HimaBinduMeda
Contributor Kevin Rushforth <kcr@openjdk.org> successfully added.

[HimaBinduMeda]

/contributor add jbhaskar

[openjdk]

@HimaBinduMeda
Contributor Jay Bhaskar <jbhaskar@openjdk.org> successfully added.

[kevinrushforth]

As a note to reviewers, this is a very large patch (as is typical for WebKit updates) with almost all of the changes being in the native WebKit code. It's easy for changes outside of the native WebKit code to get lost in the shuffle. In addition to the shear number of changes, GitHub won't even show the entire set of diffs. In case it is helpful while reviewing, here is a pointer to a branch that has the native WebKit changes reverted, so that you can easily see the changes in the rest of the code:

master...kevinrushforth:WebKit-614.1-non-WebKit-files

[kevinrushforth]

The changes look good. I tested on all three platforms.

[arapte]

Looks good to me.
Did sanity testing on Mac. Tested by browsing through several general websites and some benchmark websites.

[mstr2]

Looks good, tested on Windows and macOS.

[openjdk]

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285881: Update WebKit to 614.1

Co-authored-by: Ambarish Rapte <arapte@openjdk.org>
Co-authored-by: Kevin Rushforth <kcr@openjdk.org>
Co-authored-by: Jay Bhaskar <jbhaskar@openjdk.org>
Reviewed-by: kcr, arapte, mstrauss, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 49a2efb: 8290527: Bump macOS GitHub actions to macOS 11
• a122cef: 8289388: Fix warnings: method is overriding a synchronized method without being synchronized
• 075cc80: 8289389: Fix warnings: type should also implement hashCode() since it overrides Object.equals()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @arapte, @johanvos) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[kevinrushforth]

@HimaBinduMeda please wait for a review from either @johanvos or @tiainen before integrating this.

[johanvos]

Building and basic testing is ok, no issues in real world apps so far.

[HimaBinduMeda]

/integrate

[openjdk]

@HimaBinduMeda
Your change (at version ef9e814) is now ready to be sponsored by a Committer.

[kevinrushforth]

/sponsor

[openjdk]

Going to push as commit 7e48413.
Since your change was applied there have been 3 commits pushed to the master branch:

• 49a2efb: 8290527: Bump macOS GitHub actions to macOS 11
• a122cef: 8289388: Fix warnings: method is overriding a synchronized method without being synchronized
• 075cc80: 8289389: Fix warnings: type should also implement hashCode() since it overrides Object.equals()

Your commit was automatically rebased without conflicts.

[openjdk]

@kevinrushforth @HimaBinduMeda Pushed as commit 7e48413.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.