Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297166: [TestBug] Fix some ignored unit test from TableViewTest #952

Conversation

andy-goryachev-oracle
Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle commented Nov 16, 2022

Re-enabled some ignored tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8297166: [TestBug] Fix some ignored unit test from TableViewTest

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/952/head:pull/952
$ git checkout pull/952

Update a local copy of the PR:
$ git checkout pull/952
$ git pull https://git.openjdk.org/jfx pull/952/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 952

View PR using the GUI difftool:
$ git pr show -t 952

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/952.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 16, 2022

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@andy-goryachev-oracle andy-goryachev-oracle marked this pull request as ready for review November 17, 2022 00:15
@openjdk openjdk bot added the rfr Ready for review label Nov 17, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 17, 2022

Webrevs

@@ -2047,8 +2051,12 @@ public TableCell<Person, String> call(TableColumn<Person, String> p) {
sl.dispose();
}

// @Ignore("Test started intermittently failing, most probably due to RT-36855 changeset")
@Test public void test_rt_34493() {
/**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this comment. If needed, we can get this information from looking at file revision history.

@openjdk
Copy link

openjdk bot commented Nov 17, 2022

@andy-goryachev-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297166: [TestBug] Fix some ignored unit test from TableViewTest

Reviewed-by: aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 74af45d: 8296556: Mark two RobotTest methods as unstable on HiDPI Windows systems

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aghaisas) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Ready to be integrated label Nov 17, 2022
@andy-goryachev-oracle
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Ready to sponsor label Nov 17, 2022
@openjdk
Copy link

openjdk bot commented Nov 17, 2022

@andy-goryachev-oracle
Your change (at version 7a64405) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 17, 2022

Going to push as commit e3e0dfd.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 626227d: 8296330: Tests: Add layout container snapping tests
  • 1ec06a8: 8206430: Use consistent pattern for startup in FX system tests
  • 74af45d: 8296556: Mark two RobotTest methods as unstable on HiDPI Windows systems

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 17, 2022
@openjdk openjdk bot closed this Nov 17, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review sponsor Ready to sponsor labels Nov 17, 2022
@openjdk
Copy link

openjdk bot commented Nov 17, 2022

@kevinrushforth @andy-goryachev-oracle Pushed as commit e3e0dfd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@andy-goryachev-oracle andy-goryachev-oracle deleted the 8297166.table.view branch November 17, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants