Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273379: GTK3 stops sending key events during drag and drop #986

Closed
wants to merge 78 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
78 commits
Select commit Hold shift + click to select a range
9397a74
Merge pull request #4 from openjdk/master
tsayao Jan 23, 2020
37519d7
Merge pull request #5 from openjdk/master
tsayao Feb 14, 2020
5dccb63
Merge pull request #6 from openjdk/master
tsayao Feb 27, 2020
6f10582
Merge pull request #7 from openjdk/master
tsayao Mar 13, 2020
de2d517
Merge pull request #8 from openjdk/master
tsayao Mar 25, 2020
e1b0372
Merge pull request #9 from openjdk/master
tsayao Apr 30, 2020
6744719
Merge pull request #10 from openjdk/master
tsayao Jun 12, 2020
04516db
Merge pull request #11 from openjdk/master
tsayao Jun 30, 2020
c95598e
Merge pull request #12 from openjdk/master
tsayao Sep 21, 2020
ce12ddd
Merge pull request #13 from openjdk/master
tsayao Nov 2, 2020
d3dd7f4
Merge pull request #14 from openjdk/master
tsayao Dec 14, 2020
d80dae4
Merge pull request #15 from openjdk/master
tsayao Jan 25, 2021
b8aad79
Merge pull request #16 from openjdk/master
tsayao Feb 1, 2021
b8a9498
Merge pull request #17 from openjdk/master
tsayao Mar 6, 2021
c442d81
Merge pull request #18 from openjdk/master
tsayao Apr 25, 2021
ba7572f
Merge branch 'openjdk:master' into master
tsayao Jun 26, 2021
e717051
Merge branch 'openjdk:master' into master
tsayao Aug 4, 2021
475d6e6
Merge branch 'openjdk:master' into master
tsayao Sep 22, 2021
2f856c2
Merge branch 'openjdk:master' into master
tsayao Jan 25, 2022
2a9cff1
Merge branch 'openjdk:master' into master
tsayao Apr 9, 2022
c37b25c
Merge branch 'openjdk:master' into master
tsayao Apr 19, 2022
3226441
Merge branch 'openjdk:master' into master
tsayao Oct 1, 2022
c6cbc62
Merge branch 'openjdk:master' into master
tsayao Dec 6, 2022
9dd9938
Merge branch 'openjdk:master' into master
tsayao Dec 10, 2022
83e231b
Merge branch 'openjdk:master' into master
tsayao Dec 18, 2022
01ae9bb
Merge branch 'openjdk:master' into master
tsayao Dec 23, 2022
4a6521b
8373379 - Fix DND keys
tsayao Nov 12, 2022
6f97561
8373379 - Fix DND keys
Dec 27, 2022
635cb89
Fix image drag
tsayao Dec 30, 2022
6c2d513
Revert "Fix image drag"
tsayao Dec 30, 2022
eea3f47
Fix DragView
tsayao Jan 2, 2023
7329349
Fix DragView 2/2
tsayao Jan 2, 2023
047c7e0
Fix DragView 3/3
tsayao Jan 2, 2023
6c62ba2
Cursors
tsayao Jan 3, 2023
5150b5c
Fix DragWindow 4/4
tsayao Jan 3, 2023
c827893
Simplify DragView paint
tsayao Jan 3, 2023
665656a
Gtk2 fixes
tsayao Jan 4, 2023
5f81a1c
Add testing
tsayao Jan 4, 2023
9eb2e79
Add test
tsayao Jan 6, 2023
13ef7ad
Improvements
tsayao Jan 6, 2023
42c9ae9
Replace g_warning
tsayao Jan 6, 2023
08d05af
Adjustments
tsayao Jan 9, 2023
236cf65
Merge branch 'openjdk:master' into master
tsayao Jan 13, 2023
b5f4d6c
Device Grab Work
tsayao Jan 13, 2023
a92b750
Merge branch 'master' into 8273379-dnd-keys
tsayao Jan 13, 2023
47e13b7
Rework events
tsayao Jan 13, 2023
f916a10
Rework
tsayao Jan 16, 2023
daade44
It works!
tsayao Jan 16, 2023
b130e74
Stop DRAG on GDK_DELETE
tsayao Jan 16, 2023
a036ce6
Fix icon size on dragview
tsayao Jan 16, 2023
ba0b54f
Fix cursor + improve drag move
tsayao Jan 16, 2023
7fe6ff4
Fix drag leave
tsayao Jan 16, 2023
04c4c95
Rework 2
tsayao Jan 17, 2023
aa5d8ae
Remove commented out code
tsayao Jan 17, 2023
4b09b5d
Typo
tsayao Jan 17, 2023
86467d9
Minor adjustments
tsayao Jan 17, 2023
5ee52e6
Fix DragView below cursor
tsayao Jan 17, 2023
f0fe997
Merge branch 'openjdk:master' into master
tsayao Jan 17, 2023
c7d8805
Merge branch 'master' into 8273379-dnd-keys
tsayao Jan 18, 2023
fb65199
Add test scenario
tsayao Jan 19, 2023
5aba566
Revert unnecessary changes
tsayao Jan 19, 2023
a6ca895
Do not rely on gdk_threads_add_idle_full to end drag as it might lead…
tsayao Jan 19, 2023
7844bfe
Merge branch 'openjdk:master' into master
tsayao Jan 21, 2023
c111b47
Merge branch 'master' into 8273379-dnd-keys
tsayao Jan 21, 2023
127677c
Better end drag
tsayao Jan 21, 2023
18a3148
Merge branch 'openjdk:master' into master
tsayao Jan 28, 2023
c0eb653
Use standard cursors
tsayao Jan 28, 2023
6618ab2
Merge branch 'openjdk:master' into master
tsayao Feb 4, 2023
8b39cd8
Merge branch 'openjdk:master' into master
tsayao Feb 10, 2023
96f2deb
Don't call gdk_device_manager_get_client_pointer() on event processing
tsayao Mar 12, 2023
aef5029
Merge branch 'openjdk:master' into master
tsayao Mar 21, 2023
65c14ad
Merge branch 'openjdk:master' into master
tsayao Mar 22, 2023
9db1c59
Merge branch 'openjdk:master' into master
tsayao Mar 23, 2023
ff57e3b
Merge branch 'openjdk:master' into master
tsayao Apr 1, 2023
0a03ab4
Merge branch 'openjdk:master' into master
tsayao Apr 7, 2023
2302657
Merge branch 'master' into 8273379-dnd-keys
tsayao Apr 15, 2023
5460a04
Merge branch 'master' into 8273379-dnd-keys
tsayao May 6, 2023
53ee86e
Merge branch 'master' into 8273379-dnd-keys
tsayao May 6, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions apps/toys/DragDrop/src/dragdrop/DragDropDuke.java
Original file line number Diff line number Diff line change
@@ -67,8 +67,9 @@ public void start(Stage stage) {
"1. Wait for the image download.\n" +
"2. Drag image and notice it's a transparent png.\n" +
"3. Notice Position changes from \"Mouse Move\" to \"Mouse Drag\".\n" +
"4. Drag over and drop on the tomato square.\n" +
"5. While dragging image, press ALT+F4 (should stop Drag).");
"4. Drag over and drop on the tomato square (should change colors).\n" +
"5. Open another instance of this Window and drag from one\ninstance to another.\n" +
"6. While dragging image, press ALT+F4 (should stop Drag).");

imageView = new ImageView(image);
imageView.setFitHeight(200D);