Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294400: Provide media support for libavcodec version 59 #119

Closed
wants to merge 1 commit into from
Closed

8294400: Provide media support for libavcodec version 59 #119

wants to merge 1 commit into from

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Nov 22, 2022

Nearly clean backport, except for the changes in gradle/verification.metadata, since that file doesn't exist in jfx11u, and a trivial merge conflict in the updated copyright line in 3 files.

CI build run on all three platforms.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294400: Provide media support for libavcodec version 59

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx11u pull/119/head:pull/119
$ git checkout pull/119

Update a local copy of the PR:
$ git checkout pull/119
$ git pull https://git.openjdk.org/jfx11u pull/119/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 119

View PR using the GUI difftool:
$ git pr show -t 119

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx11u/pull/119.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2022

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ac8382bd378c7b51ccd625af46bdf10d24176692 8294400: Provide media support for libavcodec version 59 Nov 22, 2022
@openjdk
Copy link

openjdk bot commented Nov 22, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Ready for review labels Nov 22, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2022

Webrevs

@kevinrushforth
Copy link
Member Author

Reviewer: @arapte or @johanvos

@openjdk
Copy link

openjdk bot commented Nov 23, 2022

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294400: Provide media support for libavcodec version 59

Reviewed-by: arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 16db452: 8291087: Wrong position of focus of screen reader on Windows with screen scale > 1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Nov 23, 2022
@kevinrushforth
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 23, 2022

Going to push as commit ea6091a.
Since your change was applied there have been 7 commits pushed to the master branch:

  • fb072e5: 8289541: Update ICU4C to 71.1
  • d7fa500: 8283402: Update to gcc 11.2.0 on Linux
  • e00d4fb: 8293795: [Accessibility] [Win] [Narrator] Exceptions When Deleting Text with Continuous Key Press in TextArea and TextField
  • 088509e: 8284281: [Accessibility] [Win] [Narrator] Exceptions with TextArea & TextField when deleted last char
  • c66931b: 8289542: Update JPEG Image Decoding Software to 9e
  • 01e115e: 8087557: [Win] [Accessibility, Dialogs] Alert Dialog content is not fully read by Screen Reader
  • 16db452: 8291087: Wrong position of focus of screen reader on Windows with screen scale > 1

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 23, 2022
@openjdk openjdk bot closed this Nov 23, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Nov 23, 2022
@openjdk
Copy link

openjdk bot commented Nov 23, 2022

@kevinrushforth Pushed as commit ea6091a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8294400-libav59 branch November 23, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants