Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293214: Add support for Linux/LoongArch64 #102

Closed
wants to merge 1 commit into from

Conversation

theaoqi
Copy link
Member

@theaoqi theaoqi commented Jan 9, 2023

Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx17u pull/102/head:pull/102
$ git checkout pull/102

Update a local copy of the PR:
$ git checkout pull/102
$ git pull https://git.openjdk.org/jfx17u pull/102/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 102

View PR using the GUI difftool:
$ git pr show -t 102

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx17u/pull/102.diff

@kevinrushforth
Copy link
Member

Backports to jfx17u require prior approval. You will need to seek such approval from one of the project leads before taking this PR out of Draft.

If it is approved, the timing is such that it needs to wait for about two weeks. It could possibly be slated for JavaFX 17.0.7 (the April CPU release), since it is far too late to make any changes for 17.0.6.

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2023

👋 Welcome back aoqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport cef583eef41aff3db55542d5e90423eec5601f41 8293214: Add support for Linux/LoongArch64 Jan 9, 2023
@openjdk
Copy link

openjdk bot commented Jan 9, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 9, 2023

@theaoqi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293214: Add support for Linux/LoongArch64

Reviewed-by: jvos, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • a1c4d0a: 8296654: [macos] Crash when launching JavaFX app with JDK that targets SDK 13
  • ad39770: 8087673: [TableView] TableView and TreeTableView menu button overlaps columns when using a constrained resize policy.
  • 29f878f: 8293375: add_definitions USE_SYSTEM_MALLOC when USE_SYSTEM_MALLOC is ON
  • 6e7def5: 8089009: TableView with CONSTRAINED_RESIZE_POLICY incorrectly displays a horizontal scroll bar.
  • d0579c3: 8277853: With Touch enabled devices scrollbar disappears and the table is scrolled to the beginning
  • a9c4ce0: 8299272: Update copyright header for files modified in 2022
  • 27fac39: 8301011: Change JavaFX release version to 17.0.7 in jfx17u
  • 16b72c0: 8299628: BMP top-down images fail to load after JDK-8289336
  • fb0a273: Merge
  • 24bd251: 8294779: Improve FX pages
  • ... and 4 more: https://git.openjdk.org/jfx17u/compare/66626f58852fd6cd3ac6bd106f0b3a44926f06bd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@johanvos, @kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 9, 2023
@theaoqi
Copy link
Member Author

theaoqi commented Jan 9, 2023

Thanks a lot for the quick advice, @kevinrushforth. I will further learn how to do the backports to jfx17u. Also, this backport is not in a hurry. Let's wait for the release of 17.0.6. I don't want to bother with the new releasing version:)

@theaoqi
Copy link
Member Author

theaoqi commented Jan 31, 2023

RFC and RFR. Thanks. Should I take this PR out of Draft?

@johanvos
Copy link
Collaborator

johanvos commented Feb 2, 2023

@theaoqi Yes, if you take it out of draft, I'll review it.

@theaoqi theaoqi marked this pull request as ready for review February 2, 2023 08:20
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 2, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 2, 2023

Webrevs

@johanvos
Copy link
Collaborator

johanvos commented Feb 3, 2023

I'm ok with this.
Apart from the functionality, this BP also makes it easier to backport future changes in build.gradle (because it backports a structural change in the 64-bit "detection")

@theaoqi
Copy link
Member Author

theaoqi commented Feb 3, 2023

Thanks, @johanvos !

Let's wait for a while to see if @kevinrushforth has further comments.

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@theaoqi
Copy link
Member Author

theaoqi commented Feb 3, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 3, 2023
@openjdk
Copy link

openjdk bot commented Feb 3, 2023

@theaoqi
Your change (at version 14930ae) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 4, 2023

Going to push as commit 1b99a5b.
Since your change was applied there have been 14 commits pushed to the master branch:

  • a1c4d0a: 8296654: [macos] Crash when launching JavaFX app with JDK that targets SDK 13
  • ad39770: 8087673: [TableView] TableView and TreeTableView menu button overlaps columns when using a constrained resize policy.
  • 29f878f: 8293375: add_definitions USE_SYSTEM_MALLOC when USE_SYSTEM_MALLOC is ON
  • 6e7def5: 8089009: TableView with CONSTRAINED_RESIZE_POLICY incorrectly displays a horizontal scroll bar.
  • d0579c3: 8277853: With Touch enabled devices scrollbar disappears and the table is scrolled to the beginning
  • a9c4ce0: 8299272: Update copyright header for files modified in 2022
  • 27fac39: 8301011: Change JavaFX release version to 17.0.7 in jfx17u
  • 16b72c0: 8299628: BMP top-down images fail to load after JDK-8289336
  • fb0a273: Merge
  • 24bd251: 8294779: Improve FX pages
  • ... and 4 more: https://git.openjdk.org/jfx17u/compare/66626f58852fd6cd3ac6bd106f0b3a44926f06bd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 4, 2023
@openjdk openjdk bot closed this Feb 4, 2023
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Feb 4, 2023
@openjdk openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 4, 2023
@openjdk
Copy link

openjdk bot commented Feb 4, 2023

@kevinrushforth @theaoqi Pushed as commit 1b99a5b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@theaoqi theaoqi deleted the 8293214 branch August 23, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants