New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8293214: Add support for Linux/LoongArch64 #102
Conversation
Backports to If it is approved, the timing is such that it needs to wait for about two weeks. It could possibly be slated for JavaFX 17.0.7 (the April CPU release), since it is far too late to make any changes for 17.0.6. |
👋 Welcome back aoqi! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@theaoqi This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 14 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@johanvos, @kevinrushforth) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Thanks a lot for the quick advice, @kevinrushforth. I will further learn how to do the backports to |
RFC and RFR. Thanks. Should I take this PR out of Draft? |
@theaoqi Yes, if you take it out of draft, I'll review it. |
I'm ok with this. |
Thanks, @johanvos ! Let's wait for a while to see if @kevinrushforth has further comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
/integrate |
/sponsor |
Going to push as commit 1b99a5b.
Your commit was automatically rebased without conflicts. |
@kevinrushforth @theaoqi Pushed as commit 1b99a5b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx17u pull/102/head:pull/102
$ git checkout pull/102
Update a local copy of the PR:
$ git checkout pull/102
$ git pull https://git.openjdk.org/jfx17u pull/102/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 102
View PR using the GUI difftool:
$ git pr show -t 102
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx17u/pull/102.diff