Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254676: Alert disables Tab selection when TabDragPolicy REORDER is used #115

Closed
wants to merge 1 commit into from

Conversation

johanvos
Copy link
Collaborator

@johanvos johanvos commented Mar 12, 2023

Clean backport of 8254676: Alert disables Tab selection when TabDragPolicy REORDER is used
Reviewed-by: arapte, kcr


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8254676: Alert disables Tab selection when TabDragPolicy REORDER is used

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx17u pull/115/head:pull/115
$ git checkout pull/115

Update a local copy of the PR:
$ git checkout pull/115
$ git pull https://git.openjdk.org/jfx17u pull/115/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 115

View PR using the GUI difftool:
$ git pr show -t 115

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx17u/pull/115.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 12, 2023

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport cce85806c61f8b2a9bc18996a9922daf6daa9cd8 8254676: Alert disables Tab selection when TabDragPolicy REORDER is used Mar 12, 2023
@openjdk
Copy link

openjdk bot commented Mar 12, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 12, 2023

@johanvos This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254676: Alert disables Tab selection when TabDragPolicy REORDER is used

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 12, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 12, 2023

Webrevs

@johanvos
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 12, 2023

Going to push as commit 3ec9dda.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 12, 2023
@openjdk openjdk bot closed this Mar 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 12, 2023
@openjdk
Copy link

openjdk bot commented Mar 12, 2023

@johanvos Pushed as commit 3ec9dda.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant