Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284676: TreeTableView loses sort ordering when applied on empty table #76

Closed
wants to merge 1 commit into from

Conversation

arapte
Copy link
Member

@arapte arapte commented Aug 9, 2022

Clean backport to jfx17u.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284676: TreeTableView loses sort ordering when applied on empty table

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx17u pull/76/head:pull/76
$ git checkout pull/76

Update a local copy of the PR:
$ git checkout pull/76
$ git pull https://git.openjdk.org/jfx17u pull/76/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 76

View PR using the GUI difftool:
$ git pr show -t 76

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx17u/pull/76.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 9, 2022

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 9, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 9, 2022

Webrevs

@arapte arapte changed the title 8284676: TreeTableView loses sort ordering when applied on empty table Backport 0132ac89033334ec9d9ec6149d116e8c352f89ec Aug 10, 2022
@openjdk openjdk bot changed the title Backport 0132ac89033334ec9d9ec6149d116e8c352f89ec 8284676: TreeTableView loses sort ordering when applied on empty table Aug 10, 2022
@openjdk
Copy link

openjdk bot commented Aug 10, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 10, 2022

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284676: TreeTableView loses sort ordering when applied on empty table

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 6031108: 8283786: Update to Visual Studio 2022 version 17.1.0 on Windows

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 10, 2022
@arapte
Copy link
Member Author

arapte commented Aug 10, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Aug 10, 2022

Going to push as commit e363c7a.
Since your change was applied there have been 4 commits pushed to the master branch:

  • f961fa8: 8289952: Visual Studio libs msvcp140_1.dll and msvcp140_2.dll missing from build
  • 525e854: 8289587: IllegalArgumentException: Color.rgb's red parameter (-16776961) expects color values 0-255
  • cd39e0b: 8088420: JavaFX WebView memory leak via EventListener
  • 6031108: 8283786: Update to Visual Studio 2022 version 17.1.0 on Windows

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 10, 2022
@openjdk openjdk bot closed this Aug 10, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 10, 2022
@openjdk
Copy link

openjdk bot commented Aug 10, 2022

@arapte Pushed as commit e363c7a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@arapte arapte deleted the 8284676 branch August 18, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant