Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.
/ jfx23u Public archive

Merge 397d3c3548a584927c334bc214e216fff2317f5b #36

Merged
merged 10 commits into from
Jan 21, 2025

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jan 21, 2025

Clean merge of January CPU content into jfx23u:master.

Reviewer: @johanvos

/reviewers 1


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx23u.git pull/36/head:pull/36
$ git checkout pull/36

Update a local copy of the PR:
$ git checkout pull/36
$ git pull https://git.openjdk.org/jfx23u.git pull/36/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 36

View PR using the GUI difftool:
$ git pr show -t 36

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx23u/pull/36.diff

Sorry, something went wrong.

kevinrushforth and others added 10 commits July 23, 2024 14:32
Backport-of: 1b8e08a995f81381850ebc1e15b9b3ac25eca949
Backport-of: 08971f22ce8bfe3ebff4bd2f4f93a99d2eb64a61
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 21, 2025

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 21, 2025

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Merge

Reviewed-by: jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated clean rfr Pull request is ready for review labels Jan 21, 2025
@openjdk
Copy link

openjdk bot commented Jan 21, 2025

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 1 (with at least 1 Reviewer).

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jan 21, 2025
@kevinrushforth
Copy link
Member Author

@johanvos I'll add the 23.0.2 tags shortly after I integrate this PR.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 21, 2025
@kevinrushforth
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 21, 2025

Going to push as commit aa2fcda.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 21, 2025
@openjdk openjdk bot merged commit aa2fcda into openjdk:master Jan 21, 2025
6 checks passed
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 21, 2025
@openjdk
Copy link

openjdk bot commented Jan 21, 2025

@kevinrushforth Pushed as commit aa2fcda.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Jan 21, 2025

Webrevs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants