7902: UseCompressedOopsRule has flipped comparison

[Gunde]

The UseCompressedOopsRule implementation was checking that CompressedOops were disabled for heaps larger than 32 GiB, this is the opposite of what it should do. Compressed Oops are helpful for smaller heaps.

---

Progress

• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JMC-7902: UseCompressedOopsRule has flipped comparison

Reviewers

• Christoph Langer (@RealCLanger - Committer) ⚠️ Review applies to 2dff3ea1
• Brice Dutheil (@bric3 - Author) ⚠️ Review applies to 2dff3ea1

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc pull/432/head:pull/432
$ git checkout pull/432

Update a local copy of the PR:
$ git checkout pull/432
$ git pull https://git.openjdk.org/jmc pull/432/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 432

View PR using the GUI difftool:
$ git pr show -t 432

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/432.diff

[bridgekeeper]

👋 Welcome back hdafgard! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (069ebf95)
• 00: Full (2dff3ea1)

[RealCLanger]

Good catch. Please update the copyright year before merging.

[openjdk]

@Gunde This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7902: UseCompressedOopsRule has flipped comparison

Reviewed-by: clanger, bdutheil

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 9d99d88: 7910: Fix spotless finding after JMC-7903
• 7cd2f3e: 7903: FastAccessNumberMap is slow for sparse values

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[Gunde]

/integrate

[openjdk]

Going to push as commit 1696e03.
Since your change was applied there have been 2 commits pushed to the master branch:

• 9d99d88: 7910: Fix spotless finding after JMC-7903
• 7cd2f3e: 7903: FastAccessNumberMap is slow for sparse values

Your commit was automatically rebased without conflicts.

[openjdk]

@Gunde Pushed as commit 1696e03.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.