Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7910: Fix spotless finding after JMC-7903 #433

Conversation

RealCLanger
Copy link
Collaborator

@RealCLanger RealCLanger commented Sep 29, 2022

The commit for JMC-7903 violated spotless rules by not having a line break at the end of the file (see here).


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-7910: Fix spotless finding after JMC-7903

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc pull/433/head:pull/433
$ git checkout pull/433

Update a local copy of the PR:
$ git checkout pull/433
$ git pull https://git.openjdk.org/jmc pull/433/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 433

View PR using the GUI difftool:
$ git pr show -t 433

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/433.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 29, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title JMC-7910 7910: Fix spotless finding after JMC-7903 Sep 29, 2022
@openjdk openjdk bot added the rfr label Sep 29, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 29, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 29, 2022

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7910: Fix spotless finding after JMC-7903

Reviewed-by: hdafgard

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 29, 2022
@thegreystone
Copy link
Member

@RealCLanger - good to go!

@RealCLanger
Copy link
Collaborator Author

Thanks for the quick reviews.

/integrate

@openjdk
Copy link

openjdk bot commented Sep 29, 2022

Going to push as commit 9d99d88.

@openjdk openjdk bot added the integrated label Sep 29, 2022
@openjdk openjdk bot closed this Sep 29, 2022
@openjdk
Copy link

openjdk bot commented Sep 29, 2022

@RealCLanger Pushed as commit 9d99d88.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the fix-spotless-FastAccessNumberMap branch September 29, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants