New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7910: Fix spotless finding after JMC-7903 #433
7910: Fix spotless finding after JMC-7903 #433
Conversation
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
@RealCLanger This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
@RealCLanger - good to go! |
Thanks for the quick reviews. /integrate |
Going to push as commit 9d99d88. |
@RealCLanger Pushed as commit 9d99d88. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The commit for JMC-7903 violated spotless rules by not having a line break at the end of the file (see here).
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc pull/433/head:pull/433
$ git checkout pull/433
Update a local copy of the PR:
$ git checkout pull/433
$ git pull https://git.openjdk.org/jmc pull/433/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 433
View PR using the GUI difftool:
$ git pr show -t 433
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/433.diff