New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7903321: Use a set instead of a map to record methods in class 'MethodGroup' #79
Conversation
👋 Welcome back gli! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine, but we can make it simpler. Let's see that all GHA tests are also green.
jmh-core/src/main/java/org/openjdk/jmh/generators/core/MethodGroup.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right then!
@lgxbslgx This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@shipilev Thanks for the review. /integrate |
I'll sponsor after GHAs go green. |
/sponsor |
Going to push as commit 622ed6e. |
Hi all,
This patch changes the type of the field
MethodGroup#methods
from a map to a set so that it is more suitable for its meaning.Thanks for the taking the time to review.
Best Regards,
-- Guoxiong
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmh pull/79/head:pull/79
$ git checkout pull/79
Update a local copy of the PR:
$ git checkout pull/79
$ git pull https://git.openjdk.org/jmh pull/79/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 79
View PR using the GUI difftool:
$ git pr show -t 79
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/79.diff