Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903328: Introduce a new method 'clear' in interface 'Multiset' #81

Closed
wants to merge 2 commits into from

Conversation

lgxbslgx
Copy link
Member

@lgxbslgx lgxbslgx commented Sep 25, 2022

Hi all,

This patch adds a method named clear in interface Multset and implements the method in its sub-class. A corresponding test case is added and all the test passed locally.

Thanks for taking the time to review.

Best Regards,
-- Guoxiong


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmh pull/81/head:pull/81
$ git checkout pull/81

Update a local copy of the PR:
$ git checkout pull/81
$ git pull https://git.openjdk.org/jmh pull/81/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 81

View PR using the GUI difftool:
$ git pr show -t 81

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/81.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 25, 2022

👋 Welcome back gli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title CODETOOLS-7903328 7903328: Introduce a new method 'clear' in interface 'Multiset' Sep 25, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 25, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 25, 2022

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little comment, otherwise looks good.

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@openjdk
Copy link

openjdk bot commented Sep 26, 2022

@lgxbslgx This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7903328: Introduce a new method 'clear' in interface 'Multiset'

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 26, 2022
@lgxbslgx
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 26, 2022
@openjdk
Copy link

openjdk bot commented Sep 26, 2022

@lgxbslgx
Your change (at version 7c765af) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

I'll integrate once GHAs go green.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 26, 2022

Going to push as commit fbcc4ac.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 26, 2022
@openjdk openjdk bot closed this Sep 26, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 26, 2022
@openjdk
Copy link

openjdk bot commented Sep 26, 2022

@shipilev @lgxbslgx Pushed as commit fbcc4ac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Sep 26, 2022
@lgxbslgx lgxbslgx deleted the CODETOOLS-7903328 branch September 26, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants