7903214: JOL: Complete some TODOs in VMOptions

[SteafanMrZhou]

I'm sorry about the last commit, I forgot to update my branch.
I have updated the branch synchronously, please check the PR,thanks a lot.

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• CODETOOLS-7903214: JOL: Complete some TODOs in VMOptions

Reviewers

• Aleksey Shipilev (@shipilev - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jol pull/29/head:pull/29
$ git checkout pull/29

Update a local copy of the PR:
$ git checkout pull/29
$ git pull https://git.openjdk.org/jol pull/29/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29

View PR using the GUI difftool:
$ git pr show -t 29

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jol/pull/29.diff

[bridgekeeper]

👋 Welcome back SteafanMrZhou! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (38be272f)
• 00: Full (414bffe1)

[shipilev]

Can you also please go to https://github.com/SteafanMrZhou/jol/actions/ -- and check that workflows are enabled? The PRs need to be tested, and workflows are supposed to run automatically.

[SteafanMrZhou]

Can you also please go to https://github.com/SteafanMrZhou/jol/actions/ -- and check that workflows are enabled? The PRs need to be tested, and workflows are supposed to run automatically.

The tested has completed,thanks.

[shipilev]

Ah, now I remember why these are not printed. On 32-bit VMs, where the options are not available, it would print unnecessary noise:

# WARNING: Unable to get compressed oops. java.lang.IllegalArgumentException: VM option "UseCompressedOops" does not exist
# WARNING: Unable to get compressed class pointersjava.lang.IllegalArgumentException: VM option "UseCompressedClassPointers" does not exist
# WARNING: Unable to get compressed oops. java.lang.IllegalArgumentException: VM option "UseCompressedOops" does not exist
# WARNING: the compressed oops is unavailable
# Running 32-bit HotSpot VM.
# Objects are 8 bytes aligned.
#                       ref, bool, byte, char, shrt,  int,  flt,  lng,  dbl
# Field sizes:            4,    1,    1,    2,    2,    4,    4,    8,    8
# Array element sizes:    4,    1,    1,    2,    2,    4,    4,    8,    8
# Array base offsets:    12,   12,   12,   12,   12,   12,   12,   16,   16

...

These warnings cannot be reasonably fixed by users, so there is no point in printing them.

I suggest we just drop the // TODO: lines in this patch, and move on.

[SteafanMrZhou]

Alright,I changed for a later.just wait a minute.

[openjdk]

⚠️ @SteafanMrZhou the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout steafanJOL
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@SteafanMrZhou This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7903214: JOL: Complete some TODOs in VMOptions

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[SteafanMrZhou]

Why can't PRs be merged, but integrated?

[SteafanMrZhou]

/integrate

[openjdk]

@SteafanMrZhou
Your change (at version 38be272) is now ready to be sponsored by a Committer.

[shipilev]

Bots are handling all integrations to perform checks, do proper metadata updates, etc. This is how OpenJDK infra works.

[SteafanMrZhou]

How to become a Committer of this project?Thanks a lot.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 9fd21c9.

[openjdk]

@shipilev @SteafanMrZhou Pushed as commit 9fd21c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[shipilev]

How to become a Committer of this project?

The same way as for the rest of OpenJDK and other OSS projects: accrue a track record of good contributions, reviews, involvement.