Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903263: Feature Tests - Adding five JavaTest GUI legacy automated test scripts #36

Closed
wants to merge 1 commit into from

Conversation

gollayadav
Copy link
Contributor

@gollayadav gollayadav commented Aug 26, 2022

Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine.

1.New3.java
2.New5.java
3.New6.java
4.New7.java
5.New8.java


Progress

  • Change must not contain extraneous whitespace

Issue

  • CODETOOLS-7903263: Feature Tests - Adding five JavaTest GUI legacy automated test scripts

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtharness pull/36/head:pull/36
$ git checkout pull/36

Update a local copy of the PR:
$ git checkout pull/36
$ git pull https://git.openjdk.org/jtharness pull/36/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 36

View PR using the GUI difftool:
$ git pr show -t 36

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtharness/pull/36.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 26, 2022

👋 Welcome back gollayadav! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 26, 2022
@gollayadav gollayadav changed the title 7903263: Feature Tests - Adding five JavaTest GUI legacy automated feature test scripts Feature Tests - Adding five JavaTest GUI legacy automated test scripts Aug 26, 2022
@openjdk
Copy link

openjdk bot commented Aug 26, 2022

@gollayadav This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7903263: Feature Tests - Adding five JavaTest GUI legacy automated test scripts

Reviewed-by: dbessono

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 579fd52: (follow up) additional improvement to Fix NullPointerException on a parallel run #35
  • 2b3e2b6: Fix NullPointerException on a parallel run
  • b9f4a2c: 7903255: Skip git commit ID in release file for JT Harness builds if .git folder is not available
  • bb4bc80: (build) build.number incremented to b24
  • 36fb0b9: 7903232: RunTestsCommand should also print Total/Setup/Cleanup times converted to seconds
  • b007d31: 7903232: RunTestsCommand should also print Total/Setup/Cleanup times converted to seconds
  • 575facb: 7903232: RunTestsCommand should also print Total/Setup/Cleanup times converted to seconds
  • 45fd82a: 7903224: InitialUrlFilter::isInitialUrlMatch should do early detection of incorrect initial URL passed
  • 269f060: check-dependencies.xml: fixed two typos in target names
  • 1617d48: 7903212: Feature Tests - Adding five JavaTest GUI legacy automated test scripts

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dbessono) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 26, 2022
@gollayadav gollayadav changed the title Feature Tests - Adding five JavaTest GUI legacy automated test scripts 7903263: Feature Tests - Adding five JavaTest GUI legacy automated test scripts Aug 26, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 26, 2022

Webrevs

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Aug 26, 2022
@gollayadav gollayadav changed the title 7903263: Feature Tests - Adding five JavaTest GUI legacy automated test scripts Feature Tests - Adding five JavaTest GUI legacy automated test scripts Aug 27, 2022
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 27, 2022
@gollayadav gollayadav changed the title Feature Tests - Adding five JavaTest GUI legacy automated test scripts 7903263 - Feature Tests - Adding five JavaTest GUI legacy automated test scripts Aug 27, 2022
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Aug 27, 2022
@gollayadav gollayadav changed the title 7903263 - Feature Tests - Adding five JavaTest GUI legacy automated test scripts CODETOOLS-7903263 - Feature Tests - Adding five JavaTest GUI legacy automated test scripts Aug 27, 2022
@gollayadav gollayadav changed the title CODETOOLS-7903263 - Feature Tests - Adding five JavaTest GUI legacy automated test scripts Feature Tests 7903263 - Adding five JavaTest GUI legacy automated test scripts Aug 27, 2022
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 27, 2022
@gollayadav gollayadav changed the title Feature Tests 7903263 - Adding five JavaTest GUI legacy automated test scripts 7903263 Feature Tests - Adding five JavaTest GUI legacy automated test scripts Aug 27, 2022
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Aug 27, 2022
@gollayadav gollayadav changed the title 7903263 Feature Tests - Adding five JavaTest GUI legacy automated test scripts (7903263) Feature Tests - Adding five JavaTest GUI legacy automated test scripts Aug 27, 2022
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 27, 2022
@gollayadav gollayadav changed the title (7903263) Feature Tests - Adding five JavaTest GUI legacy automated test scripts 7903263: Feature Tests - Adding five JavaTest GUI legacy automated test scripts Aug 27, 2022
@dbessono dbessono self-requested a review September 1, 2022 12:55
@dbessono
Copy link
Collaborator

dbessono commented Sep 1, 2022

thanks for more tests, double checked with JDK8/MacOS

@dbessono
Copy link
Collaborator

dbessono commented Sep 1, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 1, 2022

@dbessono The change author (@gollayadav) must issue an integrate command before the integration can be sponsored.

@gollayadav
Copy link
Contributor Author

thanks for more tests, double checked with JDK8/MacOS

Thank You for your time in reviewing the test scripts.

@gollayadav
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request requires a sponsor label Sep 1, 2022
@openjdk
Copy link

openjdk bot commented Sep 1, 2022

@gollayadav
Your change (at version 6b97e97) is now ready to be sponsored by a Committer.

@dbessono
Copy link
Collaborator

dbessono commented Sep 1, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 1, 2022

Going to push as commit 9149bb7.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 579fd52: (follow up) additional improvement to Fix NullPointerException on a parallel run #35
  • 2b3e2b6: Fix NullPointerException on a parallel run
  • b9f4a2c: 7903255: Skip git commit ID in release file for JT Harness builds if .git folder is not available
  • bb4bc80: (build) build.number incremented to b24
  • 36fb0b9: 7903232: RunTestsCommand should also print Total/Setup/Cleanup times converted to seconds
  • b007d31: 7903232: RunTestsCommand should also print Total/Setup/Cleanup times converted to seconds
  • 575facb: 7903232: RunTestsCommand should also print Total/Setup/Cleanup times converted to seconds
  • 45fd82a: 7903224: InitialUrlFilter::isInitialUrlMatch should do early detection of incorrect initial URL passed
  • 269f060: check-dependencies.xml: fixed two typos in target names
  • 1617d48: 7903212: Feature Tests - Adding five JavaTest GUI legacy automated test scripts

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 1, 2022
@openjdk openjdk bot closed this Sep 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request requires a sponsor labels Sep 1, 2022
@openjdk
Copy link

openjdk bot commented Sep 1, 2022

@dbessono @gollayadav Pushed as commit 9149bb7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants