Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODETOOLS-7903323: Review and improve performance of jtreg reporting. #125

Conversation

jonathan-gibbons
Copy link
Collaborator

@jonathan-gibbons jonathan-gibbons commented Sep 23, 2022

Please review a medium simple update to address the annoying delay between the last test being executed and jtreg exiting.

The delay is due to writing the report, a side-effect of which is to scan the entire test-suite, to determine which tests have been executed.

It is not easy/simple to optimize that default; instead, a new report mode is added, that reports on all the tests in the test files and groups given on the command line -- ignoring any additional filters such as the status filter, keyword filter and exclude list filter. As such, it has more "common-sense" semantics when rerunning tests with -status:fail.

There were no existing tests for the -report option. Tests have been added for all flavors of the -report option.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg pull/125/head:pull/125
$ git checkout pull/125

Update a local copy of the PR:
$ git checkout pull/125
$ git pull https://git.openjdk.org/jtreg pull/125/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 125

View PR using the GUI difftool:
$ git pr show -t 125

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/125.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 23, 2022

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 23, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 23, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 23, 2022

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7903323: Review and improve performance of jtreg reporting.

Reviewed-by: iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 23, 2022
@jonathan-gibbons
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 26, 2022

Going to push as commit de2c216.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 66efe4b: 7903329: Trace reasons to recompile extra property definition files

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 26, 2022
@openjdk openjdk bot closed this Sep 26, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 26, 2022
@openjdk
Copy link

openjdk bot commented Sep 26, 2022

@jonathan-gibbons Pushed as commit de2c216.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jonathan-gibbons jonathan-gibbons deleted the jtreg.7903323.report-files branch September 26, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants