Skip to content

Commit 07667ca

Browse files
committedMar 21, 2025
8352506: Simplify make/test/JtregNativeHotspot.gmk
Reviewed-by: erikj
1 parent b545b9e commit 07667ca

File tree

2 files changed

+80
-1492
lines changed

2 files changed

+80
-1492
lines changed
 

‎make/common/TestFilesCompilation.gmk

+5-2
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@ include JdkNativeCompilation.gmk
4343
# OUTPUT_DIR Where to put the resulting files
4444
# EXCLUDE A list of filenames to exclude from compilation
4545
# EXTRA_FILES List of extra files not in SOURCE_DIRS
46+
# CFLAGS List of extra CFLAGS to pass on for each test
47+
# LDFLAGS List of extra LDFLAGS to pass on for each test
48+
# LIBS List of extra LIBS to pass on for each test
4649
SetupTestFilesCompilation = $(NamedParamsMacroTemplate)
4750
define SetupTestFilesCompilationBody
4851

@@ -108,7 +111,7 @@ define SetupTestFilesCompilationBody
108111
CFLAGS := $$(TEST_CFLAGS) $$($1_CFLAGS) $$($1_CFLAGS_$$(name)), \
109112
CXXFLAGS := $$(TEST_CFLAGS) $$($1_CFLAGS) $$($1_CFLAGS_$$(name)), \
110113
LD_SET_ORIGIN := $$($1_LD_SET_ORIGIN), \
111-
LDFLAGS := $$($1_LDFLAGS_$$(name)), \
114+
LDFLAGS := $$($1_LDFLAGS) $$($1_LDFLAGS_$$(name)), \
112115
DISABLED_WARNINGS_gcc := format undef unused-but-set-variable \
113116
unused-const-variable unused-function unused-value \
114117
unused-variable, \
@@ -117,7 +120,7 @@ define SetupTestFilesCompilationBody
117120
unused-but-set-variable unused-function unused-variable, \
118121
DEFAULT_LIBCXX := false, \
119122
JDK_LIBS := $$($1_JDK_LIBS_$$(name)), \
120-
LIBS := $$($1_LIBS_$$(name)), \
123+
LIBS := $$($1_LIBS) $$($1_LIBS_$$(name)), \
121124
DEFAULT_VERSIONINFO_RESOURCE := false, \
122125
OPTIMIZATION := $$(if $$($1_OPTIMIZATION_$$(name)), $$($1_OPTIMIZATION_$$(name)), LOW), \
123126
COPY_DEBUG_SYMBOLS := $$($1_COPY_DEBUG_SYMBOLS), \

‎make/test/JtregNativeHotspot.gmk

+75-1,490
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)
Please sign in to comment.