Skip to content

Commit 5e25c48

Browse files
theoweidmannoracleTobiHartmann
authored andcommittedDec 17, 2024
8346289: Confusing phrasing in IR Framework README / User-defined Regexes
Reviewed-by: thartmann, chagedorn
1 parent fbbc7c3 commit 5e25c48

File tree

1 file changed

+1
-1
lines changed
  • test/hotspot/jtreg/compiler/lib/ir_framework

1 file changed

+1
-1
lines changed
 

‎test/hotspot/jtreg/compiler/lib/ir_framework/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ More examples can be found in [IRExample](../../../testlibrary_tests/ir_framewor
103103

104104
#### User-defined Regexes
105105

106-
The user can also directly specify user-defined regexes in combination with a required compile phase (there is no default compile phase known by the framework for custom regexes). If such a user-defined regex represents a not yet supported C2 IR node, it is highly encouraged to directly add a new IR node placeholder string definition to [IRNode](./IRNode.java) for it instead together with a static regex mapping block.
106+
The user can also directly specify user-defined regexes in combination with a required compile phase (there is no default compile phase known by the framework for custom regexes). If a user-defined regex corresponds to a C2 IR node that is not yet supported, it is recommended to add a new placeholder string definition for the IR node to [IRNode](./IRNode.java), along with a corresponding static regex mapping block.
107107

108108
#### Default Compile Phase
109109
When not specifying any compile phase with `phase` in [@IR](./IR.java) (or explicitly setting `CompilePhase.DEFAULT`), the framework will perform IR matching on a default compile phase which for most IR nodes is `CompilePhase.PRINT_IDEAL` (output of flag `-XX:+PrintIdeal`, the state of the machine independent ideal graph after applying optimizations). The default phase for each IR node is defined in the static regex mapping block below each IR node placeholder string in [IRNode](./IRNode.java).

0 commit comments

Comments
 (0)
Please sign in to comment.