Skip to content

Commit 813546f

Browse files
committedAug 22, 2024
8338856: [BACKOUT] JDK-8337828: CDS: Trim down minimum GC region alignment
Reviewed-by: dcubed
1 parent 0b5c887 commit 813546f

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed
 

‎src/hotspot/share/cds/archiveHeapWriter.hpp

+5-4
Original file line numberDiff line numberDiff line change
@@ -112,10 +112,11 @@ class ArchiveHeapWriter : AllStatic {
112112
public:
113113
static const intptr_t NOCOOPS_REQUESTED_BASE = 0x10000000;
114114

115-
// The minimum region size of all collectors that are supported by CDS.
116-
// G1 heap region size can never be smaller than 1M.
117-
// Shenandoah heap region size can never be smaller than 256K.
118-
static constexpr int MIN_GC_REGION_ALIGNMENT = 256 * K;
115+
// The minimum region size of all collectors that are supported by CDS in
116+
// ArchiveHeapLoader::can_map() mode. Currently only G1 is supported. G1's region size
117+
// depends on -Xmx, but can never be smaller than 1 * M.
118+
// (TODO: Perhaps change to 256K to be compatible with Shenandoah)
119+
static constexpr int MIN_GC_REGION_ALIGNMENT = 1 * M;
119120

120121
private:
121122
class EmbeddedOopRelocator;

0 commit comments

Comments
 (0)
Please sign in to comment.