8349849: PKCS11 SunTlsKeyMaterial crashes when used with TLS1.2 TlsKeyMaterialParameterSpec

Reviewed-by: wetmore, valeriep

Author: djelinski

src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsKeyMaterialGenerator.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2005, 2022, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2005, 2025, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -119,6 +119,8 @@ protected void engineInit(AlgorithmParameterSpec params,
             mechanism = CKM_SSL3_KEY_AND_MAC_DERIVE;
         } else if (tlsVersion == 0x0301 || tlsVersion == 0x0302) {
             mechanism = CKM_TLS_KEY_AND_MAC_DERIVE;
+        } else if (tlsVersion == 0x0303) {
+            mechanism = CKM_TLS12_KEY_AND_MAC_DERIVE;
         }
     }
 

test/jdk/sun/security/pkcs11/tls/TestKeyMaterialMisuse.java

@@ -0,0 +1,87 @@
+/*
+ * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/*
+ * @test
+ * @bug 8349849
+ * @summary Verify that SunTlsKeyMaterial doesn't crash on TLS 1.2 parameters
+ * @library /test/lib ..
+ * @modules java.base/sun.security.internal.spec
+ * @run main/othervm TestKeyMaterialMisuse
+ */
+
+import sun.security.internal.spec.TlsKeyMaterialParameterSpec;
+import sun.security.internal.spec.TlsKeyMaterialSpec;
+
+import javax.crypto.KeyGenerator;
+import javax.crypto.SecretKey;
+import javax.crypto.spec.SecretKeySpec;
+import java.security.Provider;
+import java.security.ProviderException;
+import java.util.Arrays;
+import java.util.List;
+
+public class TestKeyMaterialMisuse extends PKCS11Test {
+
+    public static void main(String[] args) throws Exception {
+        System.out.println("NSS Version: " + getNSSVersion());
+        main(new TestKeyMaterialMisuse(), args);
+    }
+
+    @Override
+    public void main(Provider provider) throws Exception {
+        byte[] keyBytes = new byte[48];
+        Arrays.fill(keyBytes, (byte)1);
+        SecretKey master = new SecretKeySpec(keyBytes, "TlsMasterSecret");
+        byte[] cr = "clientRandom".getBytes();
+        byte[] sr = "serverRandom".getBytes();
+        for (int minor : List.of(1, 3)) {
+            try {
+                // the algorithms below are deliberately reversed:
+                // - SunTls12KeyMaterial is used with TLS 1.0,
+                // - SunTlsKeyMaterial is used with TLS 1.2
+                String algorithm = minor != 3 ?
+                        "SunTls12KeyMaterial" :
+                        "SunTlsKeyMaterial";
+                System.out.println("Generating key material for version: " +
+                        minor + " using algorithm: " + algorithm);
+
+                KeyGenerator g = KeyGenerator.getInstance(algorithm, provider);
+                TlsKeyMaterialParameterSpec spec =
+                        new TlsKeyMaterialParameterSpec(
+                                master, 3, minor, cr, sr,
+                                "AES", 32, 0,
+                                12, 32,
+                                "SHA-256", 32, 128);
+                g.init(spec);
+                // generateKey crashed the JVM:
+                TlsKeyMaterialSpec km = (TlsKeyMaterialSpec) g.generateKey();
+                System.out.println("Success!");
+            } catch (ProviderException e) {
+                System.out.println("Got exception, not crash:");
+                e.printStackTrace();
+            }
+        }
+    }
+
+}