Skip to content

Commit fae37aa

Browse files
committedMar 4, 2025
8345627: [REDO] Use gcc12 -ftrivial-auto-var-init=pattern in debug builds
Reviewed-by: erikj, kbarrett
1 parent 1f10ffb commit fae37aa

File tree

4 files changed

+14
-1
lines changed

4 files changed

+14
-1
lines changed
 

‎make/autoconf/flags-cflags.m4

+10
Original file line numberDiff line numberDiff line change
@@ -482,6 +482,16 @@ AC_DEFUN([FLAGS_SETUP_CFLAGS_HELPER],
482482
else
483483
DEBUG_CFLAGS_JDK="-DDEBUG"
484484
485+
if test "x$TOOLCHAIN_TYPE" = xgcc; then
486+
INIT_PATTERN_FLAG="-ftrivial-auto-var-init=pattern"
487+
FLAGS_COMPILER_CHECK_ARGUMENTS(ARGUMENT: [$INIT_PATTERN_FLAG],
488+
IF_TRUE: [
489+
DEBUG_CFLAGS_JDK="$DEBUG_CFLAGS_JDK $INIT_PATTERN_FLAG"
490+
DEBUG_CFLAGS_JVM="$INIT_PATTERN_FLAG"
491+
]
492+
)
493+
fi
494+
485495
if test "x$TOOLCHAIN_TYPE" = xclang && test "x$OPENJDK_TARGET_OS" = xaix; then
486496
DEBUG_CFLAGS_JVM="-fpic -mcmodel=large"
487497
fi

‎make/hotspot/lib/CompileGtest.gmk

+1
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ $(eval $(call SetupJdkLibrary, BUILD_GTEST_LIBJVM, \
104104
undef stringop-overflow, \
105105
DISABLED_WARNINGS_gcc_test_metaspace_misc.cpp := unused-const-variable, \
106106
DISABLED_WARNINGS_gcc_test_threadCpuLoad.cpp := address, \
107+
DISABLED_WARNINGS_gcc_test_tribool.cpp := uninitialized, \
107108
DISABLED_WARNINGS_clang := $(DISABLED_WARNINGS_clang) \
108109
undef switch format-nonliteral tautological-undefined-compare \
109110
self-assign-overloaded, \

‎make/modules/jdk.incubator.vector/Lib.gmk

+2
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ ifeq ($(call isTargetOs, linux)+$(call isTargetCpu, riscv64)+$(INCLUDE_COMPILER2
5353
DISABLED_WARNINGS_gcc := unused-function sign-compare tautological-compare ignored-qualifiers, \
5454
DISABLED_WARNINGS_clang := unused-function sign-compare tautological-compare ignored-qualifiers, \
5555
CFLAGS := -march=rv64gcv, \
56+
CFLAGS_FILTER_OUT := -ftrivial-auto-var-init=pattern, \
5657
))
5758

5859
TARGETS += $(BUILD_LIBSLEEF)
@@ -67,6 +68,7 @@ ifeq ($(call isTargetOs, linux)+$(call isTargetCpu, aarch64)+$(INCLUDE_COMPILER2
6768
DISABLED_WARNINGS_gcc := unused-function sign-compare tautological-compare ignored-qualifiers, \
6869
DISABLED_WARNINGS_clang := unused-function sign-compare tautological-compare ignored-qualifiers, \
6970
vector_math_sve.c_CFLAGS := $(SVE_CFLAGS), \
71+
CFLAGS_FILTER_OUT := -ftrivial-auto-var-init=pattern, \
7072
))
7173

7274
TARGETS += $(BUILD_LIBSLEEF)

‎test/lib/jdk/test/lib/jvmti/jvmti_common.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ get_thread_info(jvmtiEnv *jvmti, JNIEnv* jni, jthread thread) {
283283

284284
static jint
285285
get_thread_state(jvmtiEnv *jvmti, JNIEnv* jni, jthread thread) {
286-
jint thread_state;
286+
jint thread_state = 0;
287287
jvmtiError err = jvmti->GetThreadState(thread, &thread_state);
288288
check_jvmti_status(jni, err, "get_thread_state: error in JVMTI GetThreadState call");
289289
return thread_state;

0 commit comments

Comments
 (0)
Please sign in to comment.