Skip to content

Commit 16a34e8

Browse files
committedJun 21, 2023
8310384: Add hooks for custom image creation
Reviewed-by: mikael, alanb
1 parent 226c6a0 commit 16a34e8

File tree

1 file changed

+19
-12
lines changed

1 file changed

+19
-12
lines changed
 

‎make/Images.gmk

+19-12
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#
2-
# Copyright (c) 2014, 2022, Oracle and/or its affiliates. All rights reserved.
2+
# Copyright (c) 2014, 2023, Oracle and/or its affiliates. All rights reserved.
33
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
#
55
# This code is free software; you can redistribute it and/or modify it
@@ -29,6 +29,7 @@ include $(SPEC)
2929
include MakeBase.gmk
3030
include Execute.gmk
3131
include Modules.gmk
32+
include Utils.gmk
3233

3334
JDK_TARGETS :=
3435
JRE_TARGETS :=
@@ -39,7 +40,7 @@ $(eval $(call IncludeCustomExtension, Images-pre.gmk))
3940
################################################################################
4041

4142
# All modules for the current target platform.
42-
ALL_MODULES := $(call FindAllModules)
43+
ALL_MODULES := $(call FindAllModules) $(EXTRA_MODULES)
4344

4445
$(eval $(call ReadImportMetaData))
4546

@@ -54,7 +55,10 @@ JDK_MODULES_LIST := $(call CommaList, $(JDK_MODULES))
5455

5556
BASE_RELEASE_FILE := $(JDK_OUTPUTDIR)/release
5657

57-
JMODS := $(wildcard $(IMAGES_OUTPUTDIR)/jmods/*.jmod)
58+
JMODS_DIRS := $(EXTRA_JMODS_DIR) $(IMAGES_OUTPUTDIR)/jmods
59+
60+
JDK_JMODS := $(foreach m, $(JDK_MODULES), $(firstword $(wildcard $(addsuffix /$m.jmod, $(JMODS_DIRS)))))
61+
JRE_JMODS := $(foreach m, $(JRE_MODULES), $(firstword $(wildcard $(addsuffix /$m.jmod, $(JMODS_DIRS)))))
5862

5963
JLINK_ORDER_RESOURCES := **module-info.class
6064
JLINK_JLI_CLASSES :=
@@ -71,7 +75,7 @@ JLINK_ORDER_RESOURCES += \
7175
#
7276

7377
JLINK_TOOL := $(JLINK) -J-Djlink.debug=true \
74-
--module-path $(IMAGES_OUTPUTDIR)/jmods \
78+
--module-path $(call PathList, $(JMODS_DIRS)) \
7579
--endian $(OPENJDK_TARGET_CPU_ENDIAN) \
7680
--release-info $(BASE_RELEASE_FILE) \
7781
--order-resources=$(call CommaList, $(JLINK_ORDER_RESOURCES)) \
@@ -87,12 +91,15 @@ endif
8791

8892
JLINK_DISABLE_WARNINGS := | ( $(GREP) -v -e "WARNING: Using incubator module" || test "$$?" = "1" )
8993

94+
JDK_IMAGE_SUPPORT_DIR := $(SUPPORT_OUTPUTDIR)/images/jdk
95+
JRE_IMAGE_SUPPORT_DIR := $(SUPPORT_OUTPUTDIR)/images/jre
96+
9097
$(eval $(call SetupExecute, jlink_jdk, \
9198
WARN := Creating jdk image, \
92-
DEPS := $(JMODS) $(BASE_RELEASE_FILE) \
93-
$(call DependOnVariable, JDK_MODULES_LIST), \
99+
DEPS := $(JDK_JMODS) $(BASE_RELEASE_FILE) \
100+
$(call DependOnVariable, JDK_MODULES_LIST, $(JDK_IMAGE_SUPPORT_DIR)/_jlink_jdk.vardeps), \
94101
OUTPUT_DIR := $(JDK_IMAGE_DIR), \
95-
SUPPORT_DIR := $(SUPPORT_OUTPUTDIR)/images/jdk, \
102+
SUPPORT_DIR := $(JDK_IMAGE_SUPPORT_DIR), \
96103
PRE_COMMAND := $(RM) -r $(JDK_IMAGE_DIR), \
97104
COMMAND := $(JLINK_TOOL) --add-modules $(JDK_MODULES_LIST) \
98105
$(JLINK_JDK_EXTRA_OPTS) --output $(JDK_IMAGE_DIR) \
@@ -103,10 +110,10 @@ JLINK_JDK_TARGETS := $(jlink_jdk)
103110

104111
$(eval $(call SetupExecute, jlink_jre, \
105112
WARN := Creating legacy jre image, \
106-
DEPS := $(JMODS) $(BASE_RELEASE_FILE) \
107-
$(call DependOnVariable, JDK_MODULES_LIST), \
113+
DEPS := $(JRE_JMODS) $(BASE_RELEASE_FILE) \
114+
$(call DependOnVariable, JRE_MODULES_LIST, $(JRE_IMAGE_SUPPORT_DIR)/_jlink_jre.vardeps), \
108115
OUTPUT_DIR := $(JRE_IMAGE_DIR), \
109-
SUPPORT_DIR := $(SUPPORT_OUTPUTDIR)/images/jre, \
116+
SUPPORT_DIR := $(JRE_IMAGE_SUPPORT_DIR), \
110117
PRE_COMMAND := $(RM) -r $(JRE_IMAGE_DIR), \
111118
COMMAND := $(JLINK_TOOL) --add-modules $(JRE_MODULES_LIST) \
112119
$(JLINK_JRE_EXTRA_OPTS) --output $(JRE_IMAGE_DIR), \
@@ -142,7 +149,7 @@ define CreateCDSArchive
142149
INFO := Using CDS flags for $1: $$($1_$2_CDS_DUMP_FLAGS), \
143150
DEPS := $$(jlink_jdk), \
144151
OUTPUT_FILE := $$(JDK_IMAGE_DIR)/$$($1_$2_CDS_ARCHIVE), \
145-
SUPPORT_DIR := $$(SUPPORT_OUTPUTDIR)/images/jdk, \
152+
SUPPORT_DIR := $$(JDK_IMAGE_SUPPORT_DIR), \
146153
COMMAND := $$(FIXPATH) $$(JDK_IMAGE_DIR)/bin/java -Xshare:dump \
147154
-XX:SharedArchiveFile=$$(JDK_IMAGE_DIR)/$$($1_$2_CDS_ARCHIVE) \
148155
-$1 $$($1_$2_DUMP_EXTRA_ARG) $$($1_$2_CDS_DUMP_FLAGS) $$(LOG_INFO), \
@@ -155,7 +162,7 @@ define CreateCDSArchive
155162
INFO := Using CDS flags for $1: $$($1_$2_CDS_DUMP_FLAGS), \
156163
DEPS := $$(jlink_jre), \
157164
OUTPUT_FILE := $$(JRE_IMAGE_DIR)/$$($1_$2_CDS_ARCHIVE), \
158-
SUPPORT_DIR := $$(SUPPORT_OUTPUTDIR)/images/jre, \
165+
SUPPORT_DIR := $$(JRE_IMAGE_SUPPORT_DIR), \
159166
COMMAND := $$(FIXPATH) $$(JRE_IMAGE_DIR)/bin/java -Xshare:dump \
160167
-XX:SharedArchiveFile=$$(JRE_IMAGE_DIR)/$$($1_$2_CDS_ARCHIVE) \
161168
-$1 $$($1_$2_DUMP_EXTRA_ARG) $$($1_$2_CDS_DUMP_FLAGS) $$(LOG_INFO), \

0 commit comments

Comments
 (0)
Please sign in to comment.