Skip to content

Commit 26c03c1

Browse files
committedJun 23, 2022
8288719: [arm32] SafeFetch32 thumb interleaving causes random crashes
8284997: arm32 build crashes since JDK-8283326 Reviewed-by: snazarki, xliu, lucy
1 parent a802b98 commit 26c03c1

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed
 

‎src/hotspot/os_cpu/linux_arm/safefetch_linux_arm.S

+1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
.globl SafeFetch32_impl
2727
.globl _SafeFetch32_fault
2828
.globl _SafeFetch32_continuation
29+
.type SafeFetch32_impl, %function
2930

3031
# Support for int SafeFetch32(int* address, int defaultval);
3132
#

‎src/hotspot/share/runtime/safefetch.hpp

+1-2
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,10 @@
3434
#ifdef _WIN32
3535
// Windows uses Structured Exception Handling
3636
#include "safefetch_windows.hpp"
37-
#elif defined(ZERO) || defined (_AIX) || defined (ARM32)
37+
#elif defined(ZERO) || defined (_AIX)
3838
// These platforms implement safefetch via Posix sigsetjmp/longjmp.
3939
// This is slower than the other methods and uses more thread stack,
4040
// but its safe and portable.
41-
// (arm32 uses sigsetjmp/longjmp as long as JDK-8284997 is not solved)
4241
#include "safefetch_sigjmp.hpp"
4342
#define SAFEFETCH_METHOD_SIGSETJMP
4443
#else

0 commit comments

Comments
 (0)
Please sign in to comment.