|
| 1 | +/* |
| 2 | + * Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved. |
| 3 | + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 | + * |
| 5 | + * This code is free software; you can redistribute it and/or modify it |
| 6 | + * under the terms of the GNU General Public License version 2 only, as |
| 7 | + * published by the Free Software Foundation. |
| 8 | + * |
| 9 | + * This code is distributed in the hope that it will be useful, but WITHOUT |
| 10 | + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
| 11 | + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
| 12 | + * version 2 for more details (a copy is included in the LICENSE file that |
| 13 | + * accompanied this code). |
| 14 | + * |
| 15 | + * You should have received a copy of the GNU General Public License version |
| 16 | + * 2 along with this work; if not, write to the Free Software Foundation, |
| 17 | + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
| 18 | + * |
| 19 | + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
| 20 | + * or visit www.oracle.com if you need additional information or have any |
| 21 | + * questions. |
| 22 | + */ |
| 23 | + |
| 24 | +/* |
| 25 | + * @test |
| 26 | + * @bug 8293590 |
| 27 | + * @summary URL built-in protocol handlers should parse the URL early |
| 28 | + * to avoid constructing URLs for which openConnection |
| 29 | + * would later throw an exception, when possible. |
| 30 | + * A jdk.net.url.delayParsing property allows to switch that |
| 31 | + * behavior off to mitigate risks of regression |
| 32 | + * @run junit EarlyOrDelayedParsing |
| 33 | + * @run junit/othervm -Djdk.net.url.delayParsing EarlyOrDelayedParsing |
| 34 | + * @run junit/othervm -Djdk.net.url.delayParsing=true EarlyOrDelayedParsing |
| 35 | + * @run junit/othervm -Djdk.net.url.delayParsing=false EarlyOrDelayedParsing |
| 36 | + */ |
| 37 | + |
| 38 | +import java.io.IOException; |
| 39 | +import java.net.ConnectException; |
| 40 | +import java.net.MalformedURLException; |
| 41 | +import java.net.URL; |
| 42 | +import java.net.UnknownHostException; |
| 43 | +import java.util.ArrayList; |
| 44 | +import java.util.List; |
| 45 | +import java.util.stream.IntStream; |
| 46 | +import java.util.stream.Stream; |
| 47 | + |
| 48 | +import org.junit.jupiter.params.ParameterizedTest; |
| 49 | +import org.junit.jupiter.params.provider.MethodSource; |
| 50 | + |
| 51 | +import static java.lang.System.err; |
| 52 | +import static org.junit.jupiter.api.Assertions.*; |
| 53 | + |
| 54 | +public class EarlyOrDelayedParsing { |
| 55 | + |
| 56 | + public final boolean EARLY_PARSING; |
| 57 | + { |
| 58 | + String value = System.getProperty("jdk.net.url.delayParsing", "false"); |
| 59 | + EARLY_PARSING = !value.isEmpty() && !Boolean.parseBoolean(value); |
| 60 | + } |
| 61 | + |
| 62 | + // Some characters that when included at the wrong place |
| 63 | + // in the authority component, without being escaped, would |
| 64 | + // cause an exception. |
| 65 | + private static final String EXCLUDED_DELIMS = "<>\" "; |
| 66 | + private static final String UNWISE = "{}|\\^`"; |
| 67 | + private static final String DELIMS = "[]/?#@"; |
| 68 | + |
| 69 | + // Test data used to test exceptions thrown by URL |
| 70 | + // at some point, when constructed with some illegal input. |
| 71 | + sealed interface URLArgTest |
| 72 | + permits OneArgTest, TwoArgsTest, ThreeArgsTest, FourArgsTest { |
| 73 | + |
| 74 | + // Some character that is expected to cause an exception |
| 75 | + // at some point, and which this test case is built for |
| 76 | + int character(); |
| 77 | + |
| 78 | + // An URL string containing the illegal character |
| 79 | + String url(); |
| 80 | + |
| 81 | + // Some characters are already checked at construction |
| 82 | + // time. They will cause an exception to be thrown, |
| 83 | + // whether delayed parsing is activated or not. |
| 84 | + // This method returns true if an exception is |
| 85 | + // expected at construction time for this test case, |
| 86 | + // even when delayed parsing is activated. |
| 87 | + boolean early(int c); |
| 88 | + |
| 89 | + // The URL scheme this test case is built for. |
| 90 | + // Typically, one of "http", "https", "ftp"... |
| 91 | + default String scheme() { |
| 92 | + return scheme(url()); |
| 93 | + } |
| 94 | + |
| 95 | + // Return the URL string of this test case, after |
| 96 | + // substituting its scheme with the given scheme. |
| 97 | + default String urlWithScheme(String scheme) { |
| 98 | + String url = url(); |
| 99 | + int colon = url.indexOf(':'); |
| 100 | + String urlWithScheme = scheme + url.substring(colon); |
| 101 | + return urlWithScheme; |
| 102 | + } |
| 103 | + |
| 104 | + // Which exception to expect when parsing is delayed |
| 105 | + default boolean acceptDelayedException(Throwable exception) { |
| 106 | + return exception instanceof MalformedURLException |
| 107 | + || exception instanceof UnknownHostException; |
| 108 | + } |
| 109 | + |
| 110 | + default String describe() { |
| 111 | + return this.getClass().getSimpleName() + "(url=" + url() + ")"; |
| 112 | + } |
| 113 | + |
| 114 | + static int port(String protocol) { |
| 115 | + return switch (protocol) { |
| 116 | + case "http" -> 80; |
| 117 | + case "https" -> 443; |
| 118 | + case "ftp" -> 21; |
| 119 | + default -> -1; |
| 120 | + }; |
| 121 | + } |
| 122 | + |
| 123 | + static String scheme(String url) { |
| 124 | + return url.substring(0, url.indexOf(':')); |
| 125 | + } |
| 126 | + } |
| 127 | + |
| 128 | + // Test data for the one arg constructor |
| 129 | + // public URL(String spec) throws MalformedURLException |
| 130 | + sealed interface OneArgTest extends URLArgTest { |
| 131 | + |
| 132 | + // Create a new test case identical to this one but |
| 133 | + // with a different URL scheme |
| 134 | + default OneArgTest withScheme(String scheme) { |
| 135 | + String urlWithScheme = urlWithScheme(scheme); |
| 136 | + if (this instanceof OfHost) { |
| 137 | + return new OfHost(character(), urlWithScheme); |
| 138 | + } |
| 139 | + if (this instanceof OfUserInfo) { |
| 140 | + return new OfUserInfo(character(), urlWithScheme); |
| 141 | + } |
| 142 | + throw new AssertionError("unexpected subclass: " + this.getClass()); |
| 143 | + } |
| 144 | + |
| 145 | + @Override |
| 146 | + default boolean early(int c) { |
| 147 | + return this instanceof OfHost && |
| 148 | + (c < 31 || c == 127); |
| 149 | + } |
| 150 | + |
| 151 | + @Override |
| 152 | + default boolean acceptDelayedException(Throwable exception) { |
| 153 | + return URLArgTest.super.acceptDelayedException(exception) |
| 154 | + || "file".equalsIgnoreCase(scheme()) |
| 155 | + && character() == '\\' |
| 156 | + && exception instanceof IOException; |
| 157 | + } |
| 158 | + |
| 159 | + record OfHost(int character, String url) implements OneArgTest { } |
| 160 | + record OfUserInfo(int character, String url) implements OneArgTest { } |
| 161 | + |
| 162 | + static OneArgTest ofHost(int c) { |
| 163 | + return new OfHost(c, "http://local%shost/".formatted(Character.toString(c))); |
| 164 | + } |
| 165 | + static OneArgTest ofUserInfo(int c) { |
| 166 | + return new OfUserInfo(c, "http://user%sinfo@localhost:9999/".formatted(Character.toString(c))); |
| 167 | + } |
| 168 | + } |
| 169 | + |
| 170 | + // Test data for the two arg constructor |
| 171 | + // public URL(URL context, String spec) throws MalformedURLException |
| 172 | + sealed interface TwoArgsTest extends URLArgTest { |
| 173 | + |
| 174 | + // Create a new test case identical to this one but |
| 175 | + // with a different URL scheme |
| 176 | + default TwoArgsTest withScheme(String scheme) { |
| 177 | + String urlWithScheme = urlWithScheme(scheme); |
| 178 | + if (this instanceof OfTwoArgsHost) { |
| 179 | + return new OfTwoArgsHost(character(), urlWithScheme); |
| 180 | + } |
| 181 | + if (this instanceof OfTwoArgsUserInfo) { |
| 182 | + return new OfTwoArgsUserInfo(character(), urlWithScheme); |
| 183 | + } |
| 184 | + throw new AssertionError("unexpected subclass: " + this.getClass()); |
| 185 | + } |
| 186 | + |
| 187 | + @Override |
| 188 | + default boolean early(int c) { |
| 189 | + return this instanceof OfTwoArgsHost && |
| 190 | + (c < 31 || c == 127); |
| 191 | + } |
| 192 | + |
| 193 | + @Override |
| 194 | + default boolean acceptDelayedException(Throwable exception) { |
| 195 | + return URLArgTest.super.acceptDelayedException(exception) |
| 196 | + || "file".equalsIgnoreCase(scheme()) |
| 197 | + && character() == '\\' |
| 198 | + && exception instanceof IOException; |
| 199 | + } |
| 200 | + |
| 201 | + record OfTwoArgsHost(int character, String url) implements TwoArgsTest { } |
| 202 | + record OfTwoArgsUserInfo(int character, String url) implements TwoArgsTest { } |
| 203 | + |
| 204 | + static TwoArgsTest ofHost(int c) { |
| 205 | + return new OfTwoArgsHost(c, "http://local%shost/".formatted(Character.toString(c))); |
| 206 | + } |
| 207 | + static TwoArgsTest ofUserInfo(int c) { |
| 208 | + return new OfTwoArgsUserInfo(c, "http://user%sinfo@localhost:9999/".formatted(Character.toString(c))); |
| 209 | + } |
| 210 | + static TwoArgsTest ofOneArgTest(OneArgTest test) { |
| 211 | + if (test instanceof OneArgTest.OfHost) { |
| 212 | + return ofHost(test.character()); |
| 213 | + } else if (test instanceof OneArgTest.OfUserInfo) { |
| 214 | + return ofUserInfo(test.character()); |
| 215 | + } |
| 216 | + throw new AssertionError("can't convert to TwoArgsTest: " |
| 217 | + + test.getClass()); |
| 218 | + } |
| 219 | + } |
| 220 | + |
| 221 | + |
| 222 | + // Test data for the three args constructor |
| 223 | + // public URL(String scheme, String host, String file) |
| 224 | + // throws MalformedURLException |
| 225 | + sealed interface ThreeArgsTest extends URLArgTest { |
| 226 | + |
| 227 | + // the host component |
| 228 | + String host(); |
| 229 | + |
| 230 | + // the path + query components |
| 231 | + String file(); |
| 232 | + |
| 233 | + // Create a new test case identical to this one but |
| 234 | + // with a different URL scheme and port |
| 235 | + default ThreeArgsTest withScheme(String scheme) { |
| 236 | + String urlWithScheme = urlWithScheme(scheme); |
| 237 | + if (this instanceof OfHostFile) { |
| 238 | + return new OfHostFile(character(), host(), file(), urlWithScheme); |
| 239 | + } |
| 240 | + throw new AssertionError("unexpected subclass: " + this.getClass()); |
| 241 | + } |
| 242 | + |
| 243 | + @Override |
| 244 | + default boolean early(int c) { |
| 245 | + return (c < 31 || c == 127 || c == '/'); |
| 246 | + } |
| 247 | + |
| 248 | + @Override |
| 249 | + default boolean acceptDelayedException(Throwable exception) { |
| 250 | + return URLArgTest.super.acceptDelayedException(exception) |
| 251 | + || "file".equalsIgnoreCase(scheme()) |
| 252 | + && exception instanceof IOException; |
| 253 | + } |
| 254 | + |
| 255 | + record OfHostFile(int character, String host, String file, String url) |
| 256 | + implements ThreeArgsTest { |
| 257 | + } |
| 258 | + |
| 259 | + static ThreeArgsTest ofHostFile(int c) { |
| 260 | + String host = "local%shost".formatted(Character.toString(c)); |
| 261 | + String url = "http://" + host + "/"; |
| 262 | + return new OfHostFile(c, host, "/", url); |
| 263 | + } |
| 264 | + } |
| 265 | + |
| 266 | + // Test data for the four args constructor |
| 267 | + // public URL(String scheme, String host, int port, String file) |
| 268 | + // throws MalformedURLException |
| 269 | + sealed interface FourArgsTest extends URLArgTest { |
| 270 | + |
| 271 | + // the host component |
| 272 | + String host(); |
| 273 | + |
| 274 | + // the port component |
| 275 | + int port(); |
| 276 | + |
| 277 | + // the path + query components |
| 278 | + String file(); |
| 279 | + |
| 280 | + // Create a new test case identical to this one but |
| 281 | + // with a different URL scheme and port |
| 282 | + default FourArgsTest withScheme(String scheme) { |
| 283 | + String urlWithScheme = urlWithScheme(scheme); |
| 284 | + if (this instanceof OfHostFilePort) { |
| 285 | + int port = URLArgTest.port(scheme); |
| 286 | + return new OfHostFilePort(character(), host(), port, file(), urlWithScheme); |
| 287 | + } |
| 288 | + throw new AssertionError("unexpected subclass: " + this.getClass()); |
| 289 | + } |
| 290 | + |
| 291 | + @Override |
| 292 | + default boolean early(int c) { |
| 293 | + return (c < 31 || c == 127 || c == '/'); |
| 294 | + } |
| 295 | + |
| 296 | + @Override |
| 297 | + default boolean acceptDelayedException(Throwable exception) { |
| 298 | + return URLArgTest.super.acceptDelayedException(exception) |
| 299 | + || "file".equalsIgnoreCase(scheme()) |
| 300 | + && exception instanceof IOException; |
| 301 | + } |
| 302 | + |
| 303 | + record OfHostFilePort(int character, String host, int port, String file, String url) |
| 304 | + implements FourArgsTest { |
| 305 | + } |
| 306 | + |
| 307 | + static FourArgsTest ofHostPortFile(int c) { |
| 308 | + String host = "local%shost".formatted(Character.toString(c)); |
| 309 | + String url = "http://" + host + "/"; |
| 310 | + int port = URLArgTest.port(URLArgTest.scheme(url)); |
| 311 | + return new OfHostFilePort(c, host, port, "/", url); |
| 312 | + } |
| 313 | + } |
| 314 | + |
| 315 | + |
| 316 | + // Generate test data for the URL one arg constructor, with variations |
| 317 | + // of the host component. |
| 318 | + static Stream<OneArgTest> oneArgHostTests() { |
| 319 | + List<OneArgTest> tests = new ArrayList<>(); |
| 320 | + List<OneArgTest> urls = new ArrayList<>(); |
| 321 | + urls.addAll((UNWISE + EXCLUDED_DELIMS).chars() |
| 322 | + .mapToObj(OneArgTest::ofHost).toList()); |
| 323 | + urls.addAll(IntStream.concat(IntStream.range(0, 31), IntStream.of(127)) |
| 324 | + .mapToObj(OneArgTest::ofHost).toList()); |
| 325 | + for (String scheme : List.of("http", "https", "ftp")) { |
| 326 | + for (var test : urls) { |
| 327 | + tests.add(test.withScheme(scheme)); |
| 328 | + } |
| 329 | + } |
| 330 | + return tests.stream(); |
| 331 | + } |
| 332 | + |
| 333 | + // Generate test data for the URL one arg constructor, with variations |
| 334 | + // of the user info component. |
| 335 | + static Stream<OneArgTest> oneArgUserInfoTests() { |
| 336 | + List<OneArgTest> tests = new ArrayList<>(); |
| 337 | + List<OneArgTest> urls = new ArrayList<>(); |
| 338 | + urls.addAll(IntStream.concat(IntStream.range(0, 31), IntStream.of(127)) |
| 339 | + .mapToObj(OneArgTest::ofUserInfo).toList()); |
| 340 | + urls.add(OneArgTest.ofUserInfo('\\')); |
| 341 | + for (String scheme : List.of("http", "https", "ftp")) { |
| 342 | + for (var test : urls) { |
| 343 | + tests.add(test.withScheme(scheme)); |
| 344 | + } |
| 345 | + } |
| 346 | + return tests.stream(); |
| 347 | + } |
| 348 | + |
| 349 | + // Test data with all variations for the URL one arg |
| 350 | + // constructor (spec) |
| 351 | + static Stream<OneArgTest> oneArgTests() { |
| 352 | + return Stream.concat(oneArgHostTests(), oneArgUserInfoTests()); |
| 353 | + } |
| 354 | + |
| 355 | + // Test data with all variations for the URL two arg |
| 356 | + // constructor (URL, spec) |
| 357 | + static Stream<TwoArgsTest> twoArgTests() { |
| 358 | + return oneArgTests().map(TwoArgsTest::ofOneArgTest); |
| 359 | + } |
| 360 | + |
| 361 | + // Generate test data for the URL three arguments constructor |
| 362 | + // (scheme, host, file) |
| 363 | + static Stream<ThreeArgsTest> threeArgsTests() { |
| 364 | + List<ThreeArgsTest> urls = new ArrayList<>(); |
| 365 | + urls.addAll((UNWISE + EXCLUDED_DELIMS + DELIMS).chars() |
| 366 | + .mapToObj(ThreeArgsTest::ofHostFile).toList()); |
| 367 | + urls.addAll(IntStream.concat(IntStream.range(0, 31), IntStream.of(127)) |
| 368 | + .mapToObj(ThreeArgsTest::ofHostFile).toList()); |
| 369 | + List<ThreeArgsTest> tests = new ArrayList<>(); |
| 370 | + for (String scheme : List.of("http", "https", "ftp", "file")) { |
| 371 | + for (var test : urls) { |
| 372 | + tests.add(test.withScheme(scheme)); |
| 373 | + } |
| 374 | + } |
| 375 | + return tests.stream(); |
| 376 | + } |
| 377 | + |
| 378 | + // Generate test data for the URL four arguments constructor |
| 379 | + // (scheme, host, port, file) |
| 380 | + static Stream<FourArgsTest> fourArgsTests() { |
| 381 | + List<FourArgsTest> urls = new ArrayList<>(); |
| 382 | + urls.addAll((UNWISE + EXCLUDED_DELIMS + DELIMS).chars() |
| 383 | + .mapToObj(FourArgsTest::ofHostPortFile).toList()); |
| 384 | + urls.addAll(IntStream.concat(IntStream.range(0, 31), IntStream.of(127)) |
| 385 | + .mapToObj(FourArgsTest::ofHostPortFile).toList()); |
| 386 | + List<FourArgsTest> tests = new ArrayList<>(); |
| 387 | + for (String scheme : List.of("http", "https", "ftp", "file")) { |
| 388 | + for (var test : urls) { |
| 389 | + tests.add(test.withScheme(scheme)); |
| 390 | + } |
| 391 | + } |
| 392 | + return tests.stream(); |
| 393 | + } |
| 394 | + |
| 395 | + |
| 396 | + |
| 397 | + @ParameterizedTest |
| 398 | + @MethodSource("oneArgTests") |
| 399 | + public void testOneArgConstructor(OneArgTest test) throws Exception { |
| 400 | + |
| 401 | + int c = test.character(); |
| 402 | + String url = test.url(); |
| 403 | + if (EARLY_PARSING || test.early(c)) { |
| 404 | + err.println("Early parsing: " + test.describe()); |
| 405 | + var exception = assertThrows(MalformedURLException.class, () -> { |
| 406 | + new URL(url); |
| 407 | + }); |
| 408 | + err.println("Got expected exception: " + exception); |
| 409 | + } else { |
| 410 | + err.println("Delayed parsing: " + test.describe()); |
| 411 | + URL u = new URL(url); |
| 412 | + var exception = assertThrows(IOException.class, () -> { |
| 413 | + u.openConnection().connect(); |
| 414 | + }); |
| 415 | + if (!test.acceptDelayedException(exception)) { |
| 416 | + err.println("unexpected exception type: " + exception); |
| 417 | + throw exception; |
| 418 | + } |
| 419 | + err.println("Got expected exception: " + exception); |
| 420 | + assertFalse(exception instanceof ConnectException); |
| 421 | + } |
| 422 | + } |
| 423 | + |
| 424 | + @ParameterizedTest |
| 425 | + @MethodSource("twoArgTests") |
| 426 | + public void testTwoArgConstructor(TwoArgsTest test) throws Exception { |
| 427 | + |
| 428 | + int c = test.character(); |
| 429 | + String url = test.url(); |
| 430 | + String scheme = URLArgTest.scheme(url); |
| 431 | + URL u = new URL(scheme, null,""); |
| 432 | + if (EARLY_PARSING || test.early(c)) { |
| 433 | + err.println("Early parsing: " + test.describe()); |
| 434 | + var exception = assertThrows(MalformedURLException.class, () -> { |
| 435 | + new URL(u, url); |
| 436 | + }); |
| 437 | + err.println("Got expected exception: " + exception); |
| 438 | + } else { |
| 439 | + err.println("Delayed parsing: " + test.describe()); |
| 440 | + URL u2 = new URL(u, url); |
| 441 | + var exception = assertThrows(IOException.class, () -> { |
| 442 | + u2.openConnection().connect(); |
| 443 | + }); |
| 444 | + if (!test.acceptDelayedException(exception)) { |
| 445 | + err.println("unexpected exception type: " + exception); |
| 446 | + throw exception; |
| 447 | + } |
| 448 | + err.println("Got expected exception: " + exception); |
| 449 | + assertFalse(exception instanceof ConnectException); |
| 450 | + } |
| 451 | + } |
| 452 | + |
| 453 | + @ParameterizedTest |
| 454 | + @MethodSource("threeArgsTests") |
| 455 | + public void testThreeArgsConstructor(ThreeArgsTest test) throws Exception { |
| 456 | + |
| 457 | + int c = test.character(); |
| 458 | + String url = test.url(); |
| 459 | + if (EARLY_PARSING || test.early(c)) { |
| 460 | + err.println("Early parsing: " + url); |
| 461 | + var exception = assertThrows(MalformedURLException.class, () -> { |
| 462 | + new URL(test.scheme(), test.host(), test.file()); |
| 463 | + }); |
| 464 | + err.println("Got expected exception: " + exception); |
| 465 | + } else { |
| 466 | + err.println("Delayed parsing: " + url); |
| 467 | + URL u = new URL(test.scheme(), test.host(), test.file()); |
| 468 | + var exception = assertThrows(IOException.class, () -> { |
| 469 | + u.openConnection().connect(); |
| 470 | + }); |
| 471 | + if (!test.acceptDelayedException(exception)) { |
| 472 | + err.println("unexpected exception type: " + exception); |
| 473 | + throw exception; |
| 474 | + } |
| 475 | + err.println("Got expected exception: " + exception); |
| 476 | + assertFalse(exception instanceof ConnectException); |
| 477 | + } |
| 478 | + } |
| 479 | + |
| 480 | + @ParameterizedTest |
| 481 | + @MethodSource("fourArgsTests") |
| 482 | + public void testFourArgsConstructor(FourArgsTest test) throws Exception { |
| 483 | + |
| 484 | + int c = test.character(); |
| 485 | + String url = test.url(); |
| 486 | + if (EARLY_PARSING || test.early(c)) { |
| 487 | + err.println("Early parsing: " + url); |
| 488 | + var exception = assertThrows(MalformedURLException.class, () -> { |
| 489 | + new URL(test.scheme(), test.host(), test.port(), test.file()); |
| 490 | + }); |
| 491 | + err.println("Got expected exception: " + exception); |
| 492 | + } else { |
| 493 | + err.println("Delayed parsing: " + url); |
| 494 | + URL u = new URL(test.scheme(), test.host(), test.port(), test.file()); |
| 495 | + var exception = assertThrows(IOException.class, () -> { |
| 496 | + u.openConnection().connect(); |
| 497 | + }); |
| 498 | + if (!test.acceptDelayedException(exception)) { |
| 499 | + err.println("unexpected exception type: " + exception); |
| 500 | + throw exception; |
| 501 | + } |
| 502 | + err.println("Got expected exception: " + exception); |
| 503 | + assertFalse(exception instanceof ConnectException); |
| 504 | + } |
| 505 | + } |
| 506 | + |
| 507 | +} |
0 commit comments