8316629: j.text.DateFormatSymbols setZoneStrings() exception is unhelpful

Justin Lu · Justin Lu · commit ef49e6c0d7e4 · 2023-09-21T21:31:37.000Z
Reviewed-by: naoto
diff --git a/src/java.base/share/classes/java/text/DateFormatSymbols.java b/src/java.base/share/classes/java/text/DateFormatSymbols.java
@@ -612,7 +612,8 @@ public void setZoneStrings(String[][] newZoneStrings) {
         for (int i = 0; i < newZoneStrings.length; ++i) {
             int len = newZoneStrings[i].length;
             if (len < 5) {
-                throw new IllegalArgumentException();
+                throw new IllegalArgumentException(String.format(
+                        "Row %s of the input array does not have a length of at least 5", i));
             }
             aCopy[i] = Arrays.copyOf(newZoneStrings[i], len);
         }

Original file line number	Diff line number	Diff line change
`@@ -612,7 +612,8 @@ public void setZoneStrings(String[][] newZoneStrings) {`
`612`	`612`	`for (int i = 0; i < newZoneStrings.length; ++i) {`
`613`	`613`	`int len = newZoneStrings[i].length;`
`614`	`614`	`if (len < 5) {`
`615`		`- throw new IllegalArgumentException();`
	`615`	`+ throw new IllegalArgumentException(String.format(`
	`616`	`+ "Row %s of the input array does not have a length of at least 5", i));`
`616`	`617`	`}`
`617`	`618`	`aCopy[i] = Arrays.copyOf(newZoneStrings[i], len);`
`618`	`619`	`}`