Skip to content

Commit 0e6bb51

Browse files
Joshua Zhuadinn
Joshua Zhu
authored andcommittedSep 2, 2024
8339063: [aarch64] Skip verify_sve_vector_length after native calls if SVE supports 128 bits VL only
Reviewed-by: adinn, fgao
1 parent b1163bc commit 0e6bb51

7 files changed

+46
-27
lines changed
 

‎src/hotspot/cpu/aarch64/aarch64.ad

+2-2
Original file line numberDiff line numberDiff line change
@@ -2334,7 +2334,7 @@ bool Matcher::is_short_branch_offset(int rule, int br_size, int offset) {
23342334
// Vector width in bytes.
23352335
int Matcher::vector_width_in_bytes(BasicType bt) {
23362336
// The MaxVectorSize should have been set by detecting SVE max vector register size.
2337-
int size = MIN2((UseSVE > 0) ? 256 : 16, (int)MaxVectorSize);
2337+
int size = MIN2((UseSVE > 0) ? (int)FloatRegister::sve_vl_max : (int)FloatRegister::neon_vl, (int)MaxVectorSize);
23382338
// Minimum 2 values in vector
23392339
if (size < 2*type2aelembytes(bt)) size = 0;
23402340
// But never < 4
@@ -2373,7 +2373,7 @@ int Matcher::scalable_vector_reg_size(const BasicType bt) {
23732373

23742374
// Vector ideal reg.
23752375
uint Matcher::vector_ideal_reg(int len) {
2376-
if (UseSVE > 0 && 16 < len && len <= 256) {
2376+
if (UseSVE > 0 && FloatRegister::neon_vl < len && len <= FloatRegister::sve_vl_max) {
23772377
return Op_VecA;
23782378
}
23792379
switch(len) {

‎src/hotspot/cpu/aarch64/aarch64_vector.ad

+1-1
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ source %{
155155
}
156156

157157
int length_in_bytes = vlen * type2aelembytes(bt);
158-
if (UseSVE == 0 && length_in_bytes > 16) {
158+
if (UseSVE == 0 && length_in_bytes > FloatRegister::neon_vl) {
159159
return false;
160160
}
161161

‎src/hotspot/cpu/aarch64/aarch64_vector_ad.m4

+1-1
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ source %{
145145
}
146146

147147
int length_in_bytes = vlen * type2aelembytes(bt);
148-
if (UseSVE == 0 && length_in_bytes > 16) {
148+
if (UseSVE == 0 && length_in_bytes > FloatRegister::neon_vl) {
149149
return false;
150150
}
151151

‎src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp

+3-1
Original file line numberDiff line numberDiff line change
@@ -6413,8 +6413,10 @@ void MacroAssembler::cache_wbsync(bool is_pre) {
64136413
}
64146414

64156415
void MacroAssembler::verify_sve_vector_length(Register tmp) {
6416+
if (!UseSVE || VM_Version::get_max_supported_sve_vector_length() == FloatRegister::sve_vl_min) {
6417+
return;
6418+
}
64166419
// Make sure that native code does not change SVE vector length.
6417-
if (!UseSVE) return;
64186420
Label verify_ok;
64196421
movw(tmp, zr);
64206422
sve_inc(tmp, B);

‎src/hotspot/cpu/aarch64/register_aarch64.hpp

+8-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2000, 2023, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2000, 2024, Oracle and/or its affiliates. All rights reserved.
33
* Copyright (c) 2014, 2021, Red Hat Inc. All rights reserved.
44
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
55
*
@@ -166,7 +166,13 @@ class FloatRegister {
166166
max_slots_per_register = 4,
167167
save_slots_per_register = 2,
168168
slots_per_neon_register = 4,
169-
extra_save_slots_per_neon_register = slots_per_neon_register - save_slots_per_register
169+
extra_save_slots_per_neon_register = slots_per_neon_register - save_slots_per_register,
170+
neon_vl = 16,
171+
// VLmax: The maximum sve vector length is determined by the hardware
172+
// sve_vl_min <= VLmax <= sve_vl_max.
173+
sve_vl_min = 16,
174+
// Maximum supported vector length across all CPUs
175+
sve_vl_max = 256
170176
};
171177

172178
class FloatRegisterImpl: public AbstractRegisterImpl {

‎src/hotspot/cpu/aarch64/vm_version_aarch64.cpp

+28-19
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525

2626
#include "precompiled.hpp"
2727
#include "pauth_aarch64.hpp"
28+
#include "register_aarch64.hpp"
2829
#include "runtime/arguments.hpp"
2930
#include "runtime/globals_extension.hpp"
3031
#include "runtime/java.hpp"
@@ -44,6 +45,7 @@ int VM_Version::_zva_length;
4445
int VM_Version::_dcache_line_size;
4546
int VM_Version::_icache_line_size;
4647
int VM_Version::_initial_sve_vector_length;
48+
int VM_Version::_max_supported_sve_vector_length;
4749
bool VM_Version::_rop_protection;
4850
uintptr_t VM_Version::_pac_mask;
4951

@@ -507,30 +509,37 @@ void VM_Version::initialize() {
507509
if (UseSVE > 0) {
508510
if (FLAG_IS_DEFAULT(MaxVectorSize)) {
509511
MaxVectorSize = _initial_sve_vector_length;
510-
} else if (MaxVectorSize < 16) {
511-
warning("SVE does not support vector length less than 16 bytes. Disabling SVE.");
512+
} else if (MaxVectorSize < FloatRegister::sve_vl_min) {
513+
warning("SVE does not support vector length less than %d bytes. Disabling SVE.",
514+
FloatRegister::sve_vl_min);
512515
UseSVE = 0;
513-
} else if ((MaxVectorSize % 16) == 0 && is_power_of_2(MaxVectorSize)) {
514-
int new_vl = set_and_get_current_sve_vector_length(MaxVectorSize);
515-
_initial_sve_vector_length = new_vl;
516-
// Update MaxVectorSize to the largest supported value.
517-
if (new_vl < 0) {
518-
vm_exit_during_initialization(
519-
err_msg("Current system does not support SVE vector length for MaxVectorSize: %d",
520-
(int)MaxVectorSize));
521-
} else if (new_vl != MaxVectorSize) {
522-
warning("Current system only supports max SVE vector length %d. Set MaxVectorSize to %d",
523-
new_vl, new_vl);
524-
}
525-
MaxVectorSize = new_vl;
526-
} else {
516+
} else if (!((MaxVectorSize % FloatRegister::sve_vl_min) == 0 && is_power_of_2(MaxVectorSize))) {
527517
vm_exit_during_initialization(err_msg("Unsupported MaxVectorSize: %d", (int)MaxVectorSize));
528518
}
519+
520+
if (UseSVE > 0) {
521+
// Acquire the largest supported vector length of this machine
522+
_max_supported_sve_vector_length = set_and_get_current_sve_vector_length(FloatRegister::sve_vl_max);
523+
524+
if (MaxVectorSize != _max_supported_sve_vector_length) {
525+
int new_vl = set_and_get_current_sve_vector_length(MaxVectorSize);
526+
if (new_vl < 0) {
527+
vm_exit_during_initialization(
528+
err_msg("Current system does not support SVE vector length for MaxVectorSize: %d",
529+
(int)MaxVectorSize));
530+
} else if (new_vl != MaxVectorSize) {
531+
warning("Current system only supports max SVE vector length %d. Set MaxVectorSize to %d",
532+
new_vl, new_vl);
533+
}
534+
MaxVectorSize = new_vl;
535+
}
536+
_initial_sve_vector_length = MaxVectorSize;
537+
}
529538
}
530539

531540
if (UseSVE == 0) { // NEON
532541
int min_vector_size = 8;
533-
int max_vector_size = 16;
542+
int max_vector_size = FloatRegister::neon_vl;
534543
if (!FLAG_IS_DEFAULT(MaxVectorSize)) {
535544
if (!is_power_of_2(MaxVectorSize)) {
536545
vm_exit_during_initialization(err_msg("Unsupported MaxVectorSize: %d", (int)MaxVectorSize));
@@ -542,11 +551,11 @@ void VM_Version::initialize() {
542551
FLAG_SET_DEFAULT(MaxVectorSize, max_vector_size);
543552
}
544553
} else {
545-
FLAG_SET_DEFAULT(MaxVectorSize, 16);
554+
FLAG_SET_DEFAULT(MaxVectorSize, FloatRegister::neon_vl);
546555
}
547556
}
548557

549-
int inline_size = (UseSVE > 0 && MaxVectorSize >= 16) ? MaxVectorSize : 0;
558+
int inline_size = (UseSVE > 0 && MaxVectorSize >= FloatRegister::sve_vl_min) ? MaxVectorSize : 0;
550559
if (FLAG_IS_DEFAULT(ArrayOperationPartialInlineSize)) {
551560
FLAG_SET_DEFAULT(ArrayOperationPartialInlineSize, inline_size);
552561
} else if (ArrayOperationPartialInlineSize != 0 && ArrayOperationPartialInlineSize != inline_size) {

‎src/hotspot/cpu/aarch64/vm_version_aarch64.hpp

+3-1
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ class VM_Version : public Abstract_VM_Version {
4646
static int _dcache_line_size;
4747
static int _icache_line_size;
4848
static int _initial_sve_vector_length;
49+
static int _max_supported_sve_vector_length;
4950
static bool _rop_protection;
5051
static uintptr_t _pac_mask;
5152

@@ -164,7 +165,8 @@ enum Ampere_CPU_Model {
164165

165166
static int icache_line_size() { return _icache_line_size; }
166167
static int dcache_line_size() { return _dcache_line_size; }
167-
static int get_initial_sve_vector_length() { return _initial_sve_vector_length; };
168+
static int get_initial_sve_vector_length() { return _initial_sve_vector_length; };
169+
static int get_max_supported_sve_vector_length() { return _max_supported_sve_vector_length; };
168170

169171
// Aarch64 supports fast class initialization checks
170172
static bool supports_fast_class_init_checks() { return true; }

0 commit comments

Comments
 (0)
Please sign in to comment.