Skip to content

Commit 83b6a12

Browse files
committedOct 17, 2023
8316967: Correct the scope of vmtimer in UnregisteredClasses::load_class
Reviewed-by: iklam, jiangli
1 parent cceb0d8 commit 83b6a12

File tree

3 files changed

+3
-9
lines changed

3 files changed

+3
-9
lines changed
 

‎src/hotspot/share/cds/unregisteredClasses.cpp

+3-5
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,9 @@ InstanceKlass* UnregisteredClasses::load_class(Symbol* name, const char* path, T
4646
assert(name != nullptr, "invariant");
4747
assert(DumpSharedSpaces, "this function is only used with -Xshare:dump");
4848

49-
{
50-
PerfClassTraceTime vmtimer(ClassLoader::perf_sys_class_lookup_time(),
51-
THREAD->get_thread_stat()->perf_timers_addr(),
52-
PerfClassTraceTime::CLASS_LOAD);
53-
}
49+
PerfClassTraceTime vmtimer(ClassLoader::perf_app_classload_time(),
50+
THREAD->get_thread_stat()->perf_timers_addr(),
51+
PerfClassTraceTime::CLASS_LOAD);
5452

5553
Symbol* path_symbol = SymbolTable::new_symbol(path);
5654
Handle url_classloader = get_url_classloader(path_symbol, CHECK_NULL);

‎src/hotspot/share/classfile/classLoader.cpp

-2
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,6 @@ PerfCounter* ClassLoader::_perf_class_verify_selftime = nullptr;
123123
PerfCounter* ClassLoader::_perf_classes_linked = nullptr;
124124
PerfCounter* ClassLoader::_perf_class_link_time = nullptr;
125125
PerfCounter* ClassLoader::_perf_class_link_selftime = nullptr;
126-
PerfCounter* ClassLoader::_perf_sys_class_lookup_time = nullptr;
127126
PerfCounter* ClassLoader::_perf_shared_classload_time = nullptr;
128127
PerfCounter* ClassLoader::_perf_sys_classload_time = nullptr;
129128
PerfCounter* ClassLoader::_perf_app_classload_time = nullptr;
@@ -1377,7 +1376,6 @@ void ClassLoader::initialize(TRAPS) {
13771376
NEWPERFEVENTCOUNTER(_perf_classes_linked, SUN_CLS, "linkedClasses");
13781377
NEWPERFEVENTCOUNTER(_perf_classes_verified, SUN_CLS, "verifiedClasses");
13791378

1380-
NEWPERFTICKCOUNTER(_perf_sys_class_lookup_time, SUN_CLS, "lookupSysClassTime");
13811379
NEWPERFTICKCOUNTER(_perf_shared_classload_time, SUN_CLS, "sharedClassLoadTime");
13821380
NEWPERFTICKCOUNTER(_perf_sys_classload_time, SUN_CLS, "sysClassLoadTime");
13831381
NEWPERFTICKCOUNTER(_perf_app_classload_time, SUN_CLS, "appClassLoadTime");

‎src/hotspot/share/classfile/classLoader.hpp

-2
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,6 @@ class ClassLoader: AllStatic {
168168
static PerfCounter* _perf_classes_linked;
169169
static PerfCounter* _perf_class_link_time;
170170
static PerfCounter* _perf_class_link_selftime;
171-
static PerfCounter* _perf_sys_class_lookup_time;
172171
static PerfCounter* _perf_shared_classload_time;
173172
static PerfCounter* _perf_sys_classload_time;
174173
static PerfCounter* _perf_app_classload_time;
@@ -289,7 +288,6 @@ class ClassLoader: AllStatic {
289288
static PerfCounter* perf_classes_linked() { return _perf_classes_linked; }
290289
static PerfCounter* perf_class_link_time() { return _perf_class_link_time; }
291290
static PerfCounter* perf_class_link_selftime() { return _perf_class_link_selftime; }
292-
static PerfCounter* perf_sys_class_lookup_time() { return _perf_sys_class_lookup_time; }
293291
static PerfCounter* perf_shared_classload_time() { return _perf_shared_classload_time; }
294292
static PerfCounter* perf_sys_classload_time() { return _perf_sys_classload_time; }
295293
static PerfCounter* perf_app_classload_time() { return _perf_app_classload_time; }

0 commit comments

Comments
 (0)
Please sign in to comment.